smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(natives): routed msvc sse flags through plain CFLAGS for cargo-xwin

Browse Source 
cargo-xwin overwrites CFLAGS_<target> on the cargo it spawns and only appends plain CFLAGS/CXXFLAGS into it, so the sse4 override must use those.
This commit is contained in:
can1357
2026-07-24 10:11:02 +02:00
parent 16d33dcf72
commit e9c8a35f5a
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/natives/scripts/build-native.ts
+8 -4
View File
@@ -376,11 +376,15 @@ if (crossTarget) {
// enforces per-function target features: opus' silk/x86 SSE4.1 units fail to
// build without the feature enabled globally. The win32 x64 addon floor is
// x86-64-v2 (SSE4.2 inclusive), so enabling it for all C deps is safe.
// cargo-xwin overwrites `CFLAGS_<target>` on the cargo it spawns but appends
// the plain `CFLAGS`/`CXXFLAGS` values into it, so those are the only knobs
// that survive.
if (crossTarget.endsWith("-msvc") && targetArch === "x64") {
const envKey = `CFLAGS_${bareTriple.replace(/-/g, "_")}`;
const existing = process.env[envKey] ?? "";
const sseFlags = "-msse4.1 -msse4.2";
process.env[envKey] = existing ? `${existing} ${sseFlags}` : sseFlags;
for (const envKey of ["CFLAGS", "CXXFLAGS"]) {
const existing = process.env[envKey] ?? "";
const sseFlags = "-msse4.1 -msse4.2";
process.env[envKey] = existing ? `${existing} ${sseFlags}` : sseFlags;
}
}
// napi 3.7.0 resolves the built artifact from the FULL `--target` directory,
// but cargo-zigbuild writes under the bare triple; bridge the two so napi's