From d5fd4121151c883f9e063ddeeba88fde8b6a92bf Mon Sep 17 00:00:00 2001 From: can1357 Date: Sun, 16 Aug 2026 02:05:42 +0200 Subject: [PATCH] fix(tui): labeled single multi-select Enter as submit --- packages/coding-agent/src/modes/components/ask-dialog.ts | 2 +- packages/coding-agent/test/modes/components/ask-dialog.test.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/coding-agent/src/modes/components/ask-dialog.ts b/packages/coding-agent/src/modes/components/ask-dialog.ts index f45eae5a9..d7517da04 100644 --- a/packages/coding-agent/src/modes/components/ask-dialog.ts +++ b/packages/coding-agent/src/modes/components/ask-dialog.ts @@ -615,7 +615,7 @@ export class AskDialogComponent implements Component { } const question = this.#questions[this.#currentQuestionIndex()]; // Enter advances in multi-question dialogs and submits single-question ones. - const enterAction = this.#hasSubmitTab() ? "next" : "submit"; + const enterAction = this.#questions.length > 1 ? "next" : "submit"; const action = question?.multi ? `Space toggle · Enter ${enterAction}` : "Enter select · n note"; const tabs = this.#hasSubmitTab() ? " · Tab/←/→" : ""; if (this.#questionCanPage && indicator) { diff --git a/packages/coding-agent/test/modes/components/ask-dialog.test.ts b/packages/coding-agent/test/modes/components/ask-dialog.test.ts index e607450e0..a4056e1ee 100644 --- a/packages/coding-agent/test/modes/components/ask-dialog.test.ts +++ b/packages/coding-agent/test/modes/components/ask-dialog.test.ts @@ -622,6 +622,7 @@ describe("AskDialogComponent", () => { onCancel, onPrompt, }); + expect(render(component)).toContain("Space toggle · Enter next"); // Space toggles Option A; Enter on the plain option row confirms and // advances to Q2 instead of submitting the whole dialog (#8265 review). @@ -1014,6 +1015,7 @@ describe("AskDialogComponent", () => { onCancel: vi.fn(), onPrompt: vi.fn(), }); + expect(render(component)).toContain("Space toggle · Enter submit"); // Space selects Option A; Enter submits right away — no need to // discover the Submit tab (issue #8252).