smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(coding-agent): preserved windows ssh key stat checks

Browse Source 
Kept missing-file and directory identity validation on Windows while skipping only the Unix mode-bit rejection.

Added regression tests for Windows missing and directory identity paths.

Fixes #2850
This commit is contained in:
roboomp
2026-06-17 08:22:53 +00:00
committed by can1357
parent 1b202c9f14
commit d2bc4b02d2
2 changed files with 41 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/test/ssh/connection-manager.test.ts
+39
View File
@@ -71,6 +71,45 @@ describe("buildRemoteCommand", () => {
});
});
it("still rejects missing identity files on Windows args", async () => {
const dir = await fs.mkdtemp(path.join(os.tmpdir(), "omp-ssh-key-"));
const keyPath = path.join(dir, "missing_id_ed25519");
try {
await expect(
connectionManager.buildRemoteCommand(
{
name: "host",
host: "192.168.3.146",
keyPath,
},
"ls -la",
{ platform: "win32" },
),
).rejects.toThrow("SSH key not found");
} finally {
await fs.rm(dir, { recursive: true, force: true });
}
});
it("still rejects directory identity paths on Windows args", async () => {
const keyPath = await fs.mkdtemp(path.join(os.tmpdir(), "omp-ssh-key-"));
try {
await expect(
connectionManager.buildRemoteCommand(
{
name: "host",
host: "192.168.3.146",
keyPath,
},
"ls -la",
{ platform: "win32" },
),
).rejects.toThrow("SSH key is not a file");
} finally {
await fs.rm(keyPath, { recursive: true, force: true });
}
});
it("rejects group/world-readable identity files on Unix-like platforms", async () => {
await withLooseKey(async keyPath => {
await expect(