smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: implemented $PWD > cwd to prevent macOS symlink resolution

Browse Source 
- Replaced all direct `process.cwd()` calls with `getProjectDir()` utility function across 40+ files to centralize project directory resolution logic.
- Added `getProjectDir()` and `setProjectDir()` functions to `@oh-my-pi/pi-utils/dirs` module to provide abstracted project directory management.
- Made `SessionManager.list()` method asynchronous to support asynchronous session discovery operations.
- Updated default working directory resolution throughout codebase to use `getProjectDir()` instead of `process.cwd()` for improved project directory detection.
This commit is contained in:
can1357
2026-02-13 23:40:02 +01:00
parent f8e915e14e
commit d1e16d2101
43 changed files with 161 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/test/core/python-executor-lifecycle.test.ts
+7 -6
View File
@@ -2,6 +2,7 @@ import { afterEach, describe, expect, it, vi } from "bun:test";
import { disposeAllKernelSessions, executePython } from "@oh-my-pi/pi-coding-agent/ipy/executor";
import type { KernelExecuteResult } from "@oh-my-pi/pi-coding-agent/ipy/kernel";
import * as pythonKernel from "@oh-my-pi/pi-coding-agent/ipy/kernel";
import { getProjectDir } from "@oh-my-pi/pi-utils/dirs";
class FakeKernel {
execute = vi.fn(async () => this.result);
@@ -36,7 +37,7 @@ describe("executePython lifecycle", () => {
.spyOn(pythonKernel.PythonKernel, "start")
.mockResolvedValue(kernel as unknown as pythonKernel.PythonKernel);
await executePython("print('hi')", { kernelMode: "per-call", cwd: process.cwd() });
await executePython("print('hi')", { kernelMode: "per-call", cwd: getProjectDir() });
expect(startSpy).toHaveBeenCalledTimes(1);
expect(kernel.execute).toHaveBeenCalledTimes(1);
@@ -50,8 +51,8 @@ describe("executePython lifecycle", () => {
.spyOn(pythonKernel.PythonKernel, "start")
.mockResolvedValue(kernel as unknown as pythonKernel.PythonKernel);
await executePython("1 + 1", { kernelMode: "session", sessionId: "test-session", cwd: process.cwd() });
await executePython("2 + 2", { kernelMode: "session", sessionId: "test-session", cwd: process.cwd() });
await executePython("1 + 1", { kernelMode: "session", sessionId: "test-session", cwd: getProjectDir() });
await executePython("2 + 2", { kernelMode: "session", sessionId: "test-session", cwd: getProjectDir() });
expect(startSpy).toHaveBeenCalledTimes(1);
expect(kernel.execute).toHaveBeenCalledTimes(2);
@@ -66,12 +67,12 @@ describe("executePython lifecycle", () => {
.mockResolvedValueOnce(kernel as unknown as pythonKernel.PythonKernel)
.mockResolvedValueOnce(kernelNext as unknown as pythonKernel.PythonKernel);
await executePython("1 + 1", { kernelMode: "session", sessionId: "reset-session", cwd: process.cwd() });
await executePython("1 + 1", { kernelMode: "session", sessionId: "reset-session", cwd: getProjectDir() });
await executePython("2 + 2", {
kernelMode: "session",
sessionId: "reset-session",
reset: true,
cwd: process.cwd(),
cwd: getProjectDir(),
});
expect(startSpy).toHaveBeenCalledTimes(2);
@@ -89,7 +90,7 @@ describe("executePython lifecycle", () => {
.mockResolvedValueOnce(kernel as unknown as pythonKernel.PythonKernel)
.mockResolvedValueOnce(kernelNext as unknown as pythonKernel.PythonKernel);
await executePython("1 + 1", { kernelMode: "session", sessionId: "dead-session", cwd: process.cwd() });
await executePython("1 + 1", { kernelMode: "session", sessionId: "dead-session", cwd: getProjectDir() });
expect(startSpy).toHaveBeenCalledTimes(2);
expect(kernel.shutdown).toHaveBeenCalledTimes(1);