smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(coding-agent): implemented read-to-open tool aliasing in runtime

Browse Source 
- Canonicalized file and CLI defaults from `read` to `open` across tool registration and prompts.
- Added `resolveToolAlias()` and applied alias-normalized tool selection so legacy `read` maps to `open`.
- Updated runtime, UI, and export layers to treat `open` as first-class while preserving `read` compatibility.
- Renamed read prompt docs to `open.md`/`open-chunk.md` and refreshed system guidance to recommend `open`.
- Updated tool-related tests and expectations from `read` to `open` (including test fixtures and aliases).
This commit is contained in:
can1357
2026-04-24 19:13:11 +02:00
parent b7d881a7f8
commit c48d2e6080
42 changed files with 212 additions and 181 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/test/tools.test.ts
+6 -6
View File
@@ -14,9 +14,9 @@ import { BashTool } from "@oh-my-pi/pi-coding-agent/tools/bash";
import { CancelJobTool } from "@oh-my-pi/pi-coding-agent/tools/cancel-job";
import { FindTool } from "@oh-my-pi/pi-coding-agent/tools/find";
import { GrepTool } from "@oh-my-pi/pi-coding-agent/tools/grep";
import { OpenTool } from "@oh-my-pi/pi-coding-agent/tools/open";
import { wrapToolWithMetaNotice } from "@oh-my-pi/pi-coding-agent/tools/output-meta";
import { PollTool } from "@oh-my-pi/pi-coding-agent/tools/poll-tool";
import { ReadTool } from "@oh-my-pi/pi-coding-agent/tools/read";
import { WriteTool } from "@oh-my-pi/pi-coding-agent/tools/write";
import * as markitUtils from "@oh-my-pi/pi-coding-agent/utils/markit";
import { $which, Snowflake } from "@oh-my-pi/pi-utils";
@@ -216,7 +216,7 @@ function createTestToolContext(toolNames: string[]): AgentToolContext {
describe("Coding Agent Tools", () => {
let testDir: string;
let session: ToolSession;
let readTool: ReadTool;
let readTool: OpenTool;
let writeTool: WriteTool;
let editTool: EditTool;
let bashTool: BashTool;
@@ -235,7 +235,7 @@ describe("Coding Agent Tools", () => {
// Create tools for this test directory
session = createTestToolSession(testDir);
readTool = wrapToolWithMetaNotice(new ReadTool(session));
readTool = wrapToolWithMetaNotice(new OpenTool(session));
writeTool = wrapToolWithMetaNotice(new WriteTool(session));
editTool = wrapToolWithMetaNotice(new EditTool(session));
bashTool = wrapToolWithMetaNotice(new BashTool(session));
@@ -519,7 +519,7 @@ describe("Coding Agent Tools", () => {
fs.writeFileSync(testFile, pngBuffer);
const legacyReadTool = wrapToolWithMetaNotice(
new ReadTool(createTestToolSession(testDir, Settings.isolated({ "inspect_image.enabled": false }))),
new OpenTool(createTestToolSession(testDir, Settings.isolated({ "inspect_image.enabled": false }))),
);
const result = await legacyReadTool.execute("test-call-img-1", { path: testFile });
@@ -543,7 +543,7 @@ describe("Coding Agent Tools", () => {
fs.writeFileSync(testFile, pngBuffer);
const inspectModeReadTool = wrapToolWithMetaNotice(
new ReadTool(createTestToolSession(testDir, Settings.isolated({ "inspect_image.enabled": true }))),
new OpenTool(createTestToolSession(testDir, Settings.isolated({ "inspect_image.enabled": true }))),
);
const result = await inspectModeReadTool.execute("test-call-img-guidance", { path: testFile });
const output = getTextOutput(result);
@@ -820,7 +820,7 @@ function b() {
undefined,
createTestToolContext(["read"]),
),
).rejects.toThrow(/Use the `read` tool instead of cat\/head\/tail/);
).rejects.toThrow(/Use the `open` tool instead of cat\/head\/tail/);
});
it("should allow an explicit empty interceptor pattern list", async () => {