smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

**no more vouching! let's see how it goes for a week :)**

Browse Source
This commit is contained in:
can1357
2026-07-23 02:35:36 +02:00
parent 1f7d2ff9ea
commit bb15939414
13 changed files with 79 additions and 673 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/robomp/tests/test_github_events.py
-192
View File
@@ -956,195 +956,3 @@ def test_route_non_directive_comment_carries_no_pragmas() -> None:
assert decision.directive_pragmas == ()
# ---------- vouched-label deferred PR review ----------
def test_route_vouched_label_defers_pr_open() -> None:
decision = route(
"pull_request",
{
"action": "opened",
"pull_request": {"number": 9, "draft": False, "user": {"login": "alice", "type": "User"}},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
pr_review_trigger="vouched_label",
)
assert not decision.should_queue
assert decision.reason == "deferred to vouch label"
def test_route_vouched_label_reviews_on_label() -> None:
decision = route(
"pull_request",
{
"action": "labeled",
"label": {"name": "vouched"},
"pull_request": {
"number": 9,
"draft": False,
"user": {"login": "alice", "type": "User"},
"author_association": "CONTRIBUTOR",
},
"repository": {"full_name": "octo/widget"},
"sender": {"login": "github-actions[bot]"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
pr_review_trigger="vouched_label",
)
assert decision.should_queue
assert decision.task == "review_pr"
assert decision.issue_key == "octo/widget#9"
assert decision.submitter == "alice"
def test_route_vouched_label_ignores_other_labels() -> None:
decision = route(
"pull_request",
{
"action": "labeled",
"label": {"name": "bug"},
"pull_request": {"number": 9, "user": {"login": "alice"}},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
pr_review_trigger="vouched_label",
)
assert not decision.should_queue
def test_route_vouched_label_ready_for_review_defers_even_with_label() -> None:
# Persisted labels are NOT trusted; the workflow re-applies the label (a
# fresh `labeled` event) after re-validating, so ready_for_review defers.
decision = route(
"pull_request",
{
"action": "ready_for_review",
"pull_request": {
"number": 9,
"draft": False,
"user": {"login": "alice", "type": "User"},
"labels": [{"name": "vouched"}],
},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
pr_review_trigger="vouched_label",
)
assert not decision.should_queue
assert decision.reason == "deferred to vouch label"
def test_route_vouched_label_labeled_skips_draft() -> None:
decision = route(
"pull_request",
{
"action": "labeled",
"label": {"name": "vouched"},
"pull_request": {"number": 9, "draft": True, "user": {"login": "alice", "type": "User"}},
"repository": {"full_name": "octo/widget"},
"sender": {"login": "github-actions[bot]"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
pr_review_trigger="vouched_label",
)
assert not decision.should_queue
assert decision.reason == "draft PR"
def test_route_default_trigger_ignores_labeled() -> None:
# Backward-compat: the default "open" trigger does not route `labeled`.
decision = route(
"pull_request",
{
"action": "labeled",
"label": {"name": "vouched"},
"pull_request": {"number": 9, "user": {"login": "alice"}},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
)
assert not decision.should_queue
def test_route_vouched_label_reopened_defers_even_with_label() -> None:
# A since-denounced author must not slip through on reopen via a stale
# label; reopened always defers to a fresh gate check + re-label.
decision = route(
"pull_request",
{
"action": "reopened",
"pull_request": {
"number": 9,
"draft": False,
"user": {"login": "alice", "type": "User"},
"labels": [{"name": "vouched"}],
},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
pr_review_trigger="vouched_label",
)
assert not decision.should_queue
assert decision.reason == "deferred to vouch label"
def test_route_vouched_label_reopened_without_label_defers() -> None:
decision = route(
"pull_request",
{
"action": "reopened",
"pull_request": {"number": 9, "draft": False, "user": {"login": "alice", "type": "User"}},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
pr_review_trigger="vouched_label",
)
assert not decision.should_queue
assert decision.reason == "deferred to vouch label"
def test_route_vouched_label_rejects_manual_labeler() -> None:
# A triage/maintainer hand-adding the label must NOT trigger review.
decision = route(
"pull_request",
{
"action": "labeled",
"label": {"name": "vouched"},
"pull_request": {"number": 9, "draft": False, "user": {"login": "alice", "type": "User"}},
"repository": {"full_name": "octo/widget"},
"sender": {"login": "evilmaintainer"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
pr_review_trigger="vouched_label",
)
assert not decision.should_queue
assert "trusted labeler" in decision.reason
def test_route_vouched_label_skips_closed_pr() -> None:
# `labeled` can fire on a closed PR; never review one.
decision = route(
"pull_request",
{
"action": "labeled",
"label": {"name": "vouched"},
"pull_request": {"number": 9, "state": "closed", "user": {"login": "alice", "type": "User"}},
"repository": {"full_name": "octo/widget"},
"sender": {"login": "github-actions[bot]"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
pr_review_trigger="vouched_label",
)
assert not decision.should_queue
assert decision.reason == "PR not open"
python/robomp/tests/test_queue_dispatch.py
+3 -13
View File
@@ -1,11 +1,4 @@
"""Dispatch action -> task mapping in WorkerPool._dispatch.
Regression guard for the route<->dispatch contract: `github_events.route`
queues a `pull_request.labeled` event as a `review_pr` task in `vouched_label`
mode, so `_dispatch` MUST invoke `tasks.review_pr` for that action. It
previously only handled `opened/reopened/ready_for_review`, so every vouched
PR fell through to the no-op branch and was silently marked `done`.
"""
"""Dispatch action -> task mapping in WorkerPool._dispatch."""
from __future__ import annotations
@@ -55,15 +48,12 @@ def _pr_row(action: str, *, delivery: str = "pr1") -> EventRow:
)
@pytest.mark.parametrize("action", ["opened", "reopened", "ready_for_review", "labeled"])
@pytest.mark.parametrize("action", ["opened", "reopened", "ready_for_review"])
@pytest.mark.asyncio
async def test_dispatch_routes_pr_review_actions_to_review_pr(
settings: Settings, db: Database, monkeypatch: pytest.MonkeyPatch, action: str
) -> None:
"""Every PR action `route` can queue for review MUST reach `tasks.review_pr`.
`labeled` is the vouched-label trigger; the others are the `open` trigger.
"""
"""Every PR action `route` can queue for review MUST reach `tasks.review_pr`."""
seen: list[str] = []
async def fake_review_pr(*, payload, **_kwargs) -> None: