smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(robomp): added incoming PR review feature with classify and submit

Browse Source 
- Added `review_pr` task that checks out PR head in a detached worktree, classifies rank/type/area, and posts a batched GitHub review as `event=COMMENT`.
- Added four new host tools: `fetch_pr`, `classify_pr`, `pr_review_comment`, and `submit_pr_review`; review tools self-gate on `review_mode`, push/open-PR tools refuse when `review_mode` is set.
- Added sqlite staging table `pr_review_comments` with `stage_review_comment`, `list_staged_review_comments`, and `clear_staged_review_comments` DAOs.
- Routed `pull_request.opened/reopened/ready_for_review` to `review_pr` and extended `pull_request.closed` cleanup to any tracked PR regardless of author.
This commit is contained in:
can1357
2026-06-02 08:23:04 +02:00
parent 04cc014c16
commit b503f7d86b
30 changed files with 2392 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/robomp/tests/test_github_events.py
+117 -30
View File
@@ -131,7 +131,7 @@ def test_route_pr_conversation_uses_handle_pr_conversation() -> None:
{
"action": "created",
"comment": {"user": {"login": "alice"}, "body": "looks good"},
"issue": {"number": 9, "pull_request": {"url": "x"}},
"issue": {"number": 9, "user": {"login": BOT}, "pull_request": {"url": "x"}},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
@@ -155,7 +155,7 @@ def test_route_pr_conversation_uses_resolver_for_inflight_key() -> None:
{
"action": "created",
"comment": {"user": {"login": "alice"}, "body": "looks good"},
"issue": {"number": 9, "pull_request": {"url": "x"}},
"issue": {"number": 9, "user": {"login": BOT}, "pull_request": {"url": "x"}},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
@@ -175,7 +175,7 @@ def test_route_pr_conversation_falls_back_to_pr_key_when_resolver_misses() -> No
{
"action": "created",
"comment": {"user": {"login": "alice"}, "body": "hi"},
"issue": {"number": 9, "pull_request": {"url": "x"}},
"issue": {"number": 9, "user": {"login": BOT}, "pull_request": {"url": "x"}},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
@@ -188,6 +188,98 @@ def test_route_pr_conversation_falls_back_to_pr_key_when_resolver_misses() -> No
assert decision.issue_key == "octo/widget#9"
def test_route_incoming_pr_opened_queues_review_pr() -> None:
decision = route(
"pull_request",
{
"action": "opened",
"pull_request": {
"number": 9,
"draft": False,
"user": {"login": "alice", "type": "User"},
"author_association": "CONTRIBUTOR",
},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
)
assert decision.should_queue
assert decision.task == "review_pr"
assert decision.issue_key == "octo/widget#9"
assert decision.submitter == "alice"
assert decision.association == "CONTRIBUTOR"
def test_route_incoming_pr_opened_skips_draft_bot_and_disabled() -> None:
payload = {
"action": "opened",
"pull_request": {"number": 9, "draft": True, "user": {"login": "alice", "type": "User"}},
"repository": {"full_name": "octo/widget"},
}
assert not route("pull_request", payload, allowlist=ALLOWLIST, bot_login=BOT).should_queue
payload["pull_request"]["draft"] = False # type: ignore[index]
payload["pull_request"]["user"] = {"login": BOT, "type": "Bot"} # type: ignore[index]
assert not route("pull_request", payload, allowlist=ALLOWLIST, bot_login=BOT).should_queue
payload["pull_request"]["user"] = {"login": "alice", "type": "User"} # type: ignore[index]
disabled = route("pull_request", payload, allowlist=ALLOWLIST, bot_login=BOT, pr_review_enabled=False)
assert not disabled.should_queue
assert "disabled" in disabled.reason
def test_route_pull_request_synchronize_stays_skipped() -> None:
decision = route(
"pull_request",
{
"action": "synchronize",
"pull_request": {"number": 9, "user": {"login": "alice"}},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
)
assert not decision.should_queue
def test_route_incoming_pr_comment_skips() -> None:
decision = route(
"issue_comment",
{
"action": "created",
"comment": {"user": {"login": "alice"}, "body": "ping"},
"issue": {"number": 9, "user": {"login": "contributor"}, "pull_request": {"url": "x"}},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
)
assert not decision.should_queue
assert "incoming PR comments ignored" == decision.reason
def test_route_incoming_pr_comment_with_maintainer_mention_still_skips() -> None:
decision = route(
"issue_comment",
{
"action": "created",
"comment": {
"user": {"login": "can1357"},
"author_association": "OWNER",
"body": "@robomp-bot please re-review",
},
"issue": {"number": 9, "user": {"login": "contributor"}, "pull_request": {"url": "x"}},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
bot_login=BOT,
)
assert not decision.should_queue
assert decision.issue_key == "octo/widget#9"
assert decision.reason == "incoming PR comments ignored"
def test_route_review_only_for_bot_authored_pr() -> None:
decision = route(
"pull_request_review_comment",
@@ -238,10 +330,10 @@ def test_route_review_comment_falls_back_to_pr_key_when_resolver_misses() -> Non
assert decision.issue_key == "octo/widget#9"
def test_route_pr_closed_only_when_merged_by_bot() -> None:
def test_route_pr_closed_cleans_up_any_tracked_pr() -> None:
payload = {
"action": "closed",
"pull_request": {"number": 9, "user": {"login": BOT}, "merged": True},
"pull_request": {"number": 9, "user": {"login": "alice"}, "merged": False},
"repository": {"full_name": "octo/widget"},
}
decision = route(
@@ -254,21 +346,21 @@ def test_route_pr_closed_only_when_merged_by_bot() -> None:
assert decision.should_queue
assert decision.task == "cleanup_workspace"
assert decision.issue_key == "octo/widget#42"
assert decision.reason == "pull_request.closed"
fallback = route(
payload["pull_request"]["merged"] = True # type: ignore[index]
merged = route(
"pull_request",
payload,
allowlist=ALLOWLIST,
bot_login=BOT,
resolve_issue_from_pr=lambda _r, _n: None,
)
assert fallback.should_queue
assert fallback.task == "cleanup_workspace"
assert fallback.issue_key == "octo/widget#9"
assert fallback.submitter is None
payload["pull_request"]["merged"] = False # type: ignore[index]
assert not route("pull_request", payload, allowlist=ALLOWLIST, bot_login=BOT).should_queue
assert merged.should_queue
assert merged.task == "cleanup_workspace"
assert merged.issue_key == "octo/widget#9"
assert merged.reason == "pull_request.merged"
assert merged.submitter is None
def test_route_skips_pull_request_issues_event() -> None:
@@ -537,7 +629,7 @@ def test_route_directive_unset_for_maintainer_without_mention() -> None:
assert decision.directive is False
def test_route_directive_set_on_pr_conversation() -> None:
def test_route_directive_on_incoming_pr_conversation_is_ignored() -> None:
decision = route(
"issue_comment",
{
@@ -554,10 +646,8 @@ def test_route_directive_set_on_pr_conversation() -> None:
bot_login=BOT,
resolve_issue_from_pr=lambda _r, _n: "octo/widget#42",
)
assert decision.should_queue
assert decision.task == "handle_pr_conversation"
assert decision.directive is True
assert decision.directive_body == "change the indentation in foo.py"
assert not decision.should_queue
assert decision.reason == "incoming PR comments ignored"
def test_route_directive_set_on_review_comment() -> None:
@@ -586,7 +676,7 @@ def test_route_directive_set_on_review_comment() -> None:
# ---------- reviewer bots ----------
def test_route_reviewer_bot_comment_is_directive_without_mention() -> None:
def test_route_reviewer_bot_comment_on_incoming_pr_is_ignored() -> None:
decision = route(
"issue_comment",
{
@@ -603,11 +693,8 @@ def test_route_reviewer_bot_comment_is_directive_without_mention() -> None:
reviewer_bots=frozenset({"chatgpt-codex-connector"}),
resolve_issue_from_pr=lambda _r, _n: "octo/widget#42",
)
assert decision.should_queue
assert decision.task == "handle_pr_conversation"
assert decision.directive is True
assert decision.directive_body == "Found two issues in the diff: ..."
assert decision.directive_author == "chatgpt-codex-connector"
assert not decision.should_queue
assert decision.reason == "incoming PR comments ignored"
def test_route_reviewer_bot_review_comment_is_directive() -> None:
@@ -651,16 +738,16 @@ def test_route_random_bot_still_skipped_when_not_in_reviewer_list() -> None:
assert "bot" in decision.reason
def test_route_reviewer_bot_login_case_insensitive() -> None:
def test_route_reviewer_bot_login_case_insensitive_for_review_comments() -> None:
decision = route(
"issue_comment",
"pull_request_review_comment",
{
"action": "created",
"comment": {
"user": {"login": "ChatGPT-Codex-Connector", "type": "Bot"},
"body": "feedback",
},
"issue": {"number": 9, "pull_request": {"url": "x"}},
"pull_request": {"number": 9, "user": {"login": BOT}},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,
@@ -693,16 +780,16 @@ def test_route_directive_strips_pragmas_from_maintainer_comment() -> None:
assert decision.directive_pragmas == (("model", "gpt"), ("thinking", "low"))
def test_route_directive_strips_pragmas_from_reviewer_bot_comment() -> None:
def test_route_directive_strips_pragmas_from_reviewer_bot_review_comment() -> None:
decision = route(
"issue_comment",
"pull_request_review_comment",
{
"action": "created",
"comment": {
"user": {"login": "chatgpt-codex-connector", "type": "Bot"},
"body": "/model claude\nLeak in foo()",
},
"issue": {"number": 9, "pull_request": {"url": "x"}},
"pull_request": {"number": 9, "user": {"login": BOT}},
"repository": {"full_name": "octo/widget"},
},
allowlist=ALLOWLIST,