Merge PR #8163: fix(coding-agent): restore is*ToolResult guards on legacy pi shim (@roboomp)

2026-08-13 01:14:49 +02:00
parent ea200f1245 1fa80a89ad
commit ae5d58be2f
3 changed files with 121 additions and 1 deletions
@@ -0,0 +1,59 @@
+import { describe, expect, it } from "bun:test";
+import {
+	isBashToolResult,
+	isEditToolResult,
+	isFindToolResult,
+	isGrepToolResult,
+	isLsToolResult,
+	isReadToolResult,
+	isWriteToolResult,
+	type ToolResultEvent,
+} from "@oh-my-pi/pi-coding-agent/extensibility/legacy-pi-coding-agent-shim";
+
+// Issue #8161: pi-lean-ctx@3.9.18 imports `isEditToolResult`/`isWriteToolResult`
+// from `@earendil-works/pi-coding-agent`, which aliases to this shim. The shim's
+// `export * from "../index"` never forwarded the `is<Tool>ToolResult` guard
+// family (dropped from the public API in 10.2.3), so a named import threw Bun's
+// static "Export named X not found" error and aborted `omp install`.
+
+function resultEvent(toolName: string): ToolResultEvent {
+	return {
+		type: "tool_result",
+		toolCallId: "call-1",
+		input: {},
+		content: [],
+		isError: false,
+		toolName,
+		details: undefined,
+	};
+}
+
+describe("legacy shim tool-result guards", () => {
+	it("exports the guard family as callable functions", () => {
+		expect(typeof isBashToolResult).toBe("function");
+		expect(typeof isReadToolResult).toBe("function");
+		expect(typeof isEditToolResult).toBe("function");
+		expect(typeof isWriteToolResult).toBe("function");
+		expect(typeof isGrepToolResult).toBe("function");
+		expect(typeof isFindToolResult).toBe("function");
+		expect(typeof isLsToolResult).toBe("function");
+	});
+
+	it("narrows a tool_result event by tool name", () => {
+		expect(isEditToolResult(resultEvent("edit"))).toBe(true);
+		expect(isEditToolResult(resultEvent("write"))).toBe(false);
+
+		expect(isWriteToolResult(resultEvent("write"))).toBe(true);
+		expect(isWriteToolResult(resultEvent("edit"))).toBe(false);
+
+		expect(isBashToolResult(resultEvent("bash"))).toBe(true);
+		expect(isReadToolResult(resultEvent("read"))).toBe(true);
+		expect(isGrepToolResult(resultEvent("grep"))).toBe(true);
+		expect(isFindToolResult(resultEvent("find"))).toBe(true);
+		expect(isLsToolResult(resultEvent("ls"))).toBe(true);
+		expect(isFindToolResult(resultEvent("ls"))).toBe(false);
+		expect(isLsToolResult(resultEvent("find"))).toBe(false);
+
+		expect(isBashToolResult(resultEvent("read"))).toBe(false);
+	});
+});