smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge PR #5757: fix(task): inherit default fallback for single-model subagents (@jeffscottward)

Browse Source
This commit is contained in:
can1357
2026-07-18 20:12:48 +02:00
parent e38389a01e 6dcc485389
commit ad9d272efe
5 changed files with 262 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/test/sdk-model-selection.test.ts
+26
View File
@@ -393,6 +393,32 @@ describe("createAgentSession deferred model pattern resolution", () => {
}
});
test("installs an inherited fallback chain for a deferred singleton modelPattern", async () => {
const settings = Settings.isolated({
"retry.fallbackChains": {
default: ["runtime-provider/runtime-reasoning-model"],
},
});
settings.setModelRole("default", "runtime-provider/runtime-reasoning-model");
const { session } = await createAgentSession({
...(await buildSessionOptions("runtime-provider/runtime-model")),
settings,
modelPatternFallbackRole: "subagent:deferred-default",
modelPatternDefaultFallbackChain: ["runtime-provider/runtime-reasoning-model"],
});
try {
expect(session.model?.provider).toBe("runtime-provider");
expect(session.model?.id).toBe("runtime-model");
expect(session.settings.getModelRole("subagent:deferred-default")).toBe("runtime-provider/runtime-model");
expect(session.settings.get("retry.fallbackChains")["subagent:deferred-default"]).toEqual([
"runtime-provider/runtime-reasoning-model",
]);
} finally {
await session.dispose();
}
});
test("splits deferred comma-delimited modelPattern and installs fallback chain", async () => {
const { session } = await createAgentSession({
...(await buildSessionOptions("runtime-provider/runtime-model,runtime-provider/runtime-reasoning-model")),