smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(snapcompact): selected silver for cjk auto shape

Browse Source 
- Made resolveShapeForText choose silver16-bw for CJK-heavy auto transcripts while preserving explicit variants and unsafe glyph protection.
- Added silver16-bw to the snapcompact shape settings submenu and renamed unsupported-glyph warnings.
- Covered auto shape selection, explicit variant precedence, unsafe glyph scans, and settings option parity.

Fixes #4486
This commit is contained in:
roboomp
2026-07-04 03:54:55 +00:00
parent fef9b62334
commit a8add580d9
9 changed files with 104 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/test/agent-session-snapcompact-auto-fallback.test.ts
+6 -6
View File
@@ -147,8 +147,8 @@ describe("AgentSession auto-snapcompact local-blocker fallback", () => {
});
});
it("downgrades to context-full when the transcript is too non-ASCII for snapcompact to render", async () => {
tempDir = TempDir.createSync("@pi-snapcompact-non-ascii-");
it("downgrades to context-full when unsupported glyphs make snapcompact unsafe", async () => {
tempDir = TempDir.createSync("@pi-snapcompact-unsupported-glyphs-");
authStorage = await AuthStorage.create(path.join(tempDir.path(), "auth.db"));
const harness = await createHarness(tempDir, authStorage, {
activeModel: { provider: "aimlapi", id: "claude-sonnet-4-5-20250929" },
@@ -167,11 +167,11 @@ describe("AgentSession auto-snapcompact local-blocker fallback", () => {
expect(result.action).toBe("context-full");
expect(result.errorMessage).toBeUndefined();
expect(compactionModule.compact).toHaveBeenCalled();
const cjkNotice = harness.notices.find(message =>
message.startsWith("snapcompact disabled: high non-ASCII rate detected"),
const unsupportedGlyphNotice = harness.notices.find(message =>
message.startsWith("snapcompact disabled: unsupported characters for selected snapcompact font"),
);
expect(cjkNotice).toBeDefined();
expect(cjkNotice).toContain("using context-full auto-compaction instead.");
expect(unsupportedGlyphNotice).toBeDefined();
expect(unsupportedGlyphNotice).toContain("using context-full auto-compaction instead.");
expect(harness.sessionManager.getBranch().find(entry => entry.type === "compaction")).toMatchObject({
type: "compaction",
summary: "compacted",