fix(robomp): close lifecycle review gaps
This commit is contained in:
@@ -39,7 +39,7 @@ export function IssueCard(props: IssueCardProps): JSX.Element {
|
||||
state={item().issueState}
|
||||
classification={item().classification}
|
||||
failed={item().bucket === "failed"}
|
||||
live={item().bucket === "running"}
|
||||
live={item().live !== null || item().inflightOnly}
|
||||
/>
|
||||
</Show>
|
||||
<MetaRow item={item()} />
|
||||
@@ -52,7 +52,7 @@ export function IssueCard(props: IssueCardProps): JSX.Element {
|
||||
when={
|
||||
CONFIG.replayEnabled &&
|
||||
(item().bucket === "failed" ||
|
||||
(item().bucket === "running" && !item().inflightOnly))
|
||||
(item().bucket === "running" && item().live !== null))
|
||||
}
|
||||
>
|
||||
<div class="rmp-card-actions">
|
||||
@@ -64,7 +64,7 @@ export function IssueCard(props: IssueCardProps): JSX.Element {
|
||||
retry
|
||||
</button>
|
||||
</Show>
|
||||
<Show when={item().bucket === "running" && item().deliveryId}>
|
||||
<Show when={item().bucket === "running" && item().live !== null && item().deliveryId}>
|
||||
<button class="tiny danger" onClick={() => void cancel(item().deliveryId)}>
|
||||
cancel
|
||||
</button>
|
||||
|
||||
@@ -1,11 +1,21 @@
|
||||
import { type JSX } from "solid-js";
|
||||
import { type JSX, Show } from "solid-js";
|
||||
|
||||
import { runTrigger } from "../../state";
|
||||
import { runTrigger, triggerStatus } from "../../state";
|
||||
import { Events } from "../Events";
|
||||
import { Logs } from "../Logs";
|
||||
|
||||
const STATUS_TONE = {
|
||||
idle: "text-ink-400",
|
||||
pending: "text-ink-200",
|
||||
ok: "text-ok",
|
||||
err: "text-err",
|
||||
} as const;
|
||||
|
||||
// Activity (investigate mode). Full history table + full-height log stream.
|
||||
// Logs finally get real vertical room.
|
||||
// Logs finally get real vertical room. The shared trigger status renders right
|
||||
// under the events table so a retry fired from this view surfaces its
|
||||
// success/error where the button was clicked — the Trigger bar lives only on
|
||||
// Operations/Triage, so without this the Activity retry feedback is invisible.
|
||||
export function Activity(): JSX.Element {
|
||||
const handleRetry = (deliveryId: string): void => {
|
||||
void runTrigger({ mode: "retry", delivery_id: deliveryId });
|
||||
@@ -14,6 +24,14 @@ export function Activity(): JSX.Element {
|
||||
return (
|
||||
<>
|
||||
<Events onRetry={handleRetry} />
|
||||
<Show when={triggerStatus().text}>
|
||||
<span
|
||||
class={`rmp-activity-status ${STATUS_TONE[triggerStatus().kind]}`}
|
||||
role={triggerStatus().kind === "err" ? "alert" : "status"}
|
||||
>
|
||||
{triggerStatus().text}
|
||||
</span>
|
||||
</Show>
|
||||
<Logs />
|
||||
</>
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user