smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(coding-agent/modes): collapsed hook option descriptions in compact overflow mode

Browse Source 
- Updated hook option rendering to support description modes for full text, bounded rows, or hidden detail output.
- Adjusted compact-mode row budgeting so list height is based on labels, preventing a single description from consuming the visible budget.
- Added pre-wrapping with ellipsis truncation for selected option descriptions and updated overflow tests to validate the collapsed label-first behavior.
This commit is contained in:
can1357
2026-06-03 21:33:52 +02:00
parent 37f8d4109d
commit a1a9176c19
3 changed files with 139 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/test/hook-selector-overflow.test.ts
+29 -11
View File
@@ -95,30 +95,48 @@ describe("HookSelectorComponent", () => {
}
});
it("counts description rows toward the visible row cap", () => {
it("collapses to labels with only the highlighted description when descriptions overflow", () => {
const options = [
{ label: "Path A", description: "Reuse existing credentials." },
{ label: "Path B", description: "Authorize a provider in the browser." },
{ label: "Path C", description: "Edit provider keys manually." },
{ label: "Path D", description: "Continue with offline-only tools." },
];
const component = new HookSelectorComponent(
"Which setup path should be used?",
[
{ label: "Path A", description: "Reuse existing credentials." },
{ label: "Path B", description: "Authorize a provider in the browser." },
{ label: "Path C", description: "Edit provider keys manually." },
{ label: "Path D", description: "Continue with offline-only tools." },
],
options,
() => {},
() => {},
{ outline: true, initialIndex: 0, maxVisible: 4 },
{ outline: true, initialIndex: 0, maxVisible: 6 },
);
const plain = component
.render(76)
.map(line => Bun.stripANSI(line))
.join("\n");
// Every option label stays on screen so the user can see the whole menu...
expect(plain).toContain("Path A");
expect(plain).toContain("Reuse existing credentials.");
expect(plain).toContain("Path B");
expect(plain).toContain("Authorize a provider in the browser.");
expect(plain).not.toContain("Path C");
expect(plain).toContain("Path C");
expect(plain).toContain("Path D");
// ...but only the highlighted option expands its description.
expect(plain).toContain("Reuse existing credentials.");
expect(plain).not.toContain("Authorize a provider in the browser.");
expect(plain).not.toContain("Edit provider keys manually.");
expect(plain).toContain("(1/4)");
// The detail pane follows the cursor: moving down expands Path B and
// collapses Path A's description.
component.handleInput("\x1b[B");
const afterDown = component
.render(76)
.map(line => Bun.stripANSI(line))
.join("\n");
expect(afterDown).toContain("Path A");
expect(afterDown).toContain("Path D");
expect(afterDown).toContain("Authorize a provider in the browser.");
expect(afterDown).not.toContain("Reuse existing credentials.");
expect(afterDown).toContain("(2/4)");
});
it("counts wrapped outlined rows toward the visible row cap", () => {