smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(write): guarded xd approval evaluation failures

Browse Source 
Schema-invalid JSON objects can reach mounted approval functions before xdev dispatch validates their arguments. Fall back to the exec tier when an approval function throws, preserving fail-closed prompting and allowing dispatch to surface its normal schema error.

Added regression coverage for ast_edit payloads containing null paths.

Fixes #5727
This commit is contained in:
roboomp
2026-07-16 17:29:17 +00:00
parent 5445beb6f5
commit 912dd44068
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/test/write-xdev-dispatch.test.ts
+4 -2
View File
@@ -115,11 +115,13 @@ describe("read and write route xd:// device URLs", () => {
expect(tier("xd://debug", JSON.stringify({ action: "sessions" }))).toBe("read");
expect(tier("xd://debug", JSON.stringify({ action: "launch", program: "./app" }))).toBe("exec");
// Fail closed: malformed JSON, non-object payloads, missing content,
// and unknown devices all stay exec so the gate never under-prompts.
// Fail closed: malformed JSON, non-object or schema-invalid payloads,
// missing content, and unknown devices all stay exec so the gate never
// under-prompts.
expect(tier("xd://ast_edit", "{ not json")).toBe("exec");
expect(tier("xd://ast_edit", "[1,2,3]")).toBe("exec");
expect(tier("xd://ast_edit", '"a string"')).toBe("exec");
expect(tier("xd://ast_edit", JSON.stringify({ paths: [null] }))).toBe("exec");
expect(approval({ path: "xd://ast_edit" })).toBe("exec");
expect(tier("xd://no_such_device", "{}")).toBe("exec");
} finally {