Revert "Merge PR #5886: fix(robomp): defer rate-limited submissions (@roboomp)"

This reverts commit 81102634c8, reversing changes made to 5c9b5f7b64.
2026-07-18 21:15:38 +02:00
parent c3b9e5415d
commit 8a57bcd4f0
13 changed files with 32 additions and 377 deletions
@@ -434,7 +434,6 @@ def create_app(settings: Settings | None = None) -> FastAPI:
                cap=cap,
            )
            if not admission.accepted:
-                assert cap is not None
                window = int(cfg.rate_limit_window_seconds)
                reason = f"rate limit: @{submitter} has used {admission.used}/{cap} submissions in the last {window}s"
                log.info(
@@ -448,21 +447,17 @@ def create_app(settings: Settings | None = None) -> FastAPI:
                        "cap": cap,
                    },
                )
-                deferred = db.defer_submission_event(
+                db.record_event(
                    delivery_id=x_github_delivery,
                    event_type=x_github_event,
-                    login=submitter,
                    repo=decision.repo,
                    issue_key=decision.issue_key,
                    payload=payload,
-                    cap=cap,
-                    reason=reason,
+                    state="skipped",
+                    last_error=reason,
                )
-                event_state = "deferred" if deferred else "skipped"
-                if deferred:
-                    bag["pool"].wake()
                return JSONResponse(
-                    {"delivery": x_github_delivery, "state": event_state, "reason": "rate_limited"},
+                    {"delivery": x_github_delivery, "state": "skipped", "reason": "rate_limited"},
                    status_code=202,
                )