From 7428146556603eba0b7ec9e078c190bd7be7bf55 Mon Sep 17 00:00:00 2001 From: jwmacd Date: Sun, 2 Aug 2026 03:41:55 -0400 Subject: [PATCH] review: changelog entries; note manual /shake intent; derive RESCUE from AGGRESSIVE --- packages/agent/CHANGELOG.md | 4 ++++ packages/agent/src/compaction/shake.ts | 11 ++++++----- packages/coding-agent/CHANGELOG.md | 4 ++++ 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/packages/agent/CHANGELOG.md b/packages/agent/CHANGELOG.md index 8e3fb6a28..eec80294d 100644 --- a/packages/agent/CHANGELOG.md +++ b/packages/agent/CHANGELOG.md @@ -2,6 +2,10 @@ ## [Unreleased] +### Fixed + +- Shake no longer elides artifact recovery reads; the compaction dead-end rescue uses a dedicated `RESCUE_SHAKE_CONFIG`. + ## [17.2.4] - 2026-08-01 ### Fixed diff --git a/packages/agent/src/compaction/shake.ts b/packages/agent/src/compaction/shake.ts index 9ce9f36af..3d5289b7d 100644 --- a/packages/agent/src/compaction/shake.ts +++ b/packages/agent/src/compaction/shake.ts @@ -51,7 +51,10 @@ export const DEFAULT_SHAKE_CONFIG: ShakeConfig = { fenceMinTokens: 400, }; -/** Manual `/shake`: aggressive — drops every eligible region across history. */ +/** + * Manual `/shake`: aggressive — drops every eligible region across history, + * artifact recovery reads included (the user's full escape hatch). + */ export const AGGRESSIVE_SHAKE_CONFIG: ShakeConfig = { protectTokens: 0, minSavings: 0, @@ -61,10 +64,8 @@ export const AGGRESSIVE_SHAKE_CONFIG: ShakeConfig = { /** Compaction dead-end rescue: aggressive reach, but artifact recovery reads stay protected. */ export const RESCUE_SHAKE_CONFIG: ShakeConfig = { - protectTokens: 0, - minSavings: 0, - protectedTools: ["skill", isSkillReadToolResult, isArtifactRecoveryToolResult], - fenceMinTokens: 400, + ...AGGRESSIVE_SHAKE_CONFIG, + protectedTools: [...AGGRESSIVE_SHAKE_CONFIG.protectedTools, isArtifactRecoveryToolResult], }; /** Rough token cost of a placeholder line; used only for the savings gate. */ diff --git a/packages/coding-agent/CHANGELOG.md b/packages/coding-agent/CHANGELOG.md index 11d4830cc..2e9763154 100644 --- a/packages/coding-agent/CHANGELOG.md +++ b/packages/coding-agent/CHANGELOG.md @@ -2,6 +2,10 @@ ## [Unreleased] +### Fixed + +- Fixed shake re-eliding artifact recovery reads into a new artifact indefinitely. + ## [17.2.4] - 2026-08-01 ### Added