smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "fix(coding-agent): routed foreign aliases to binary updates"

Browse Source 
This reverts commit 834002adc5.
This commit is contained in:
can1357
2026-08-14 00:13:06 +02:00
parent 0d6a7146a3
commit 6ecb1e3383
3 changed files with 19 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/test/update-cli.test.ts
-47
View File
@@ -26,7 +26,6 @@ import {
resolveReleaseDist,
resolveReleaseRename,
resolveUpdateMethodForTest,
resolveUpdateTargetFromPathForTest,
shouldForceBinaryUpdate,
sweepStaleUpdateArtifacts,
updateViaBinaryAt,
@@ -188,52 +187,6 @@ describe("update-cli install target detection", () => {
expect(method).toBe("npm");
});
it("updates the resolved standalone binary behind a foreign npm-bin alias", async () => {
// realpath: macOS tmpdir lives behind the /var -> /private/var symlink and
// the resolver returns realpathed targets.
const dir = await fs.realpath(await makeTempDir());
const npmBinDir = path.join(dir, ".npm-global", "bin");
const standalonePath = path.join(dir, ".local", "bin", "omp");
const aliasPath = path.join(npmBinDir, "omp");
await fs.mkdir(npmBinDir, { recursive: true });
await fs.mkdir(path.dirname(standalonePath), { recursive: true });
await Bun.write(standalonePath, "binary");
await fs.symlink(standalonePath, aliasPath);
const target = resolveUpdateTargetFromPathForTest(aliasPath, undefined, {
allowPackageManagers: true,
npmBinDir,
});
expect(target).toEqual({ method: "binary", path: standalonePath, replacesSymlink: false });
expect(await fs.readlink(aliasPath)).toBe(standalonePath);
});
it("uses npm update when the bin symlink resolves into npm's global install tree", () => {
const method = resolveUpdateMethodForTest("/home/u/.npm-global/bin/omp", undefined, {
npmBinDir: "/home/u/.npm-global/bin",
ompRealpath: "/home/u/.npm-global/lib/node_modules/@oh-my-pi/pi-coding-agent/dist/cli.js",
});
expect(method).toBe("npm");
});
it("uses binary update when the bun global bin entry is a foreign alias symlink", () => {
const method = resolveUpdateMethodForTest("/home/u/.bun/bin/omp", "/home/u/.bun/bin", {
ompRealpath: "/home/u/.local/bin/omp",
});
expect(method).toBe("binary");
});
it("uses bun update when the bin symlink resolves into bun's global install tree", () => {
const method = resolveUpdateMethodForTest("/home/u/.bun/bin/omp", "/home/u/.bun/bin", {
ompRealpath: "/home/u/.bun/install/global/node_modules/@oh-my-pi/pi-coding-agent/dist/cli.js",
});
expect(method).toBe("bun");
});
it("uses binary update when prioritized omp is outside bun global bin", () => {
const method = resolveUpdateMethodForTest("/Users/test/.local/bin/omp", "/Users/test/.bun/bin");