smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: corrected resource tracking and context cleanup across MCP and virtualization layers

Browse Source 
- Fixed resource refresh tracking by storing connection references alongside promises to prevent stale deduplication.
- Fixed update target resolution to explicitly handle missing ompPath and use path.resolve() for consistent normalization.
- Added error handling and logging in Smithery registry detail fetching to gracefully handle failures and track issues.
- Fixed virtualization context cleanup in error paths to prevent partially-started instances from remaining active.
- Fixed API key retrieval to use dynamic provider configuration instead of hardcoded provider string.
- Enhanced test utilities to capture and verify request parameters for improved test coverage and debugging.
This commit is contained in:
can1357
2026-03-03 06:07:22 +01:00
parent 1f78e7fa13
commit 6357b245a5
11 changed files with 104 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/src/cli/update-cli.ts
+14 -17
View File
@@ -47,14 +47,6 @@ async function getBunGlobalBinDir(): Promise<string | undefined> {
}
}
function getRealPathOrOriginal(filePath: string): string {
try {
return fs.realpathSync(filePath);
} catch {
return filePath;
}
}
function normalizePathForComparison(filePath: string): string {
const normalized = path.normalize(filePath);
if (process.platform === "win32") return normalized.toLowerCase();
@@ -62,16 +54,13 @@ function normalizePathForComparison(filePath: string): string {
}
function isPathInDirectory(filePath: string, directoryPath: string): boolean {
const normalizedPath = normalizePathForComparison(getRealPathOrOriginal(filePath));
const normalizedDirectory = normalizePathForComparison(getRealPathOrOriginal(directoryPath));
const normalizedPath = normalizePathForComparison(path.resolve(filePath));
const normalizedDirectory = normalizePathForComparison(path.resolve(directoryPath));
const relativePath = path.relative(normalizedDirectory, normalizedPath);
return relativePath === "" || (!relativePath.startsWith("..") && !path.isAbsolute(relativePath));
}
interface UpdateTarget {
method: "bun" | "binary";
path: string;
}
type UpdateTarget = { method: "bun" } | { method: "binary"; path: string };
function resolveUpdateMethod(ompPath: string, bunBinDir: string | undefined): "bun" | "binary" {
if (!bunBinDir) return "binary";
@@ -82,10 +71,18 @@ export function _resolveUpdateMethodForTest(ompPath: string, bunBinDir: string |
return resolveUpdateMethod(ompPath, bunBinDir);
}
async function resolveUpdateTarget(): Promise<UpdateTarget> {
const ompPath = resolveOmpPath() ?? process.execPath;
const bunBinDir = await getBunGlobalBinDir();
const method = resolveUpdateMethod(ompPath, bunBinDir);
return { method, path: ompPath };
const ompPath = resolveOmpPath();
if (ompPath) {
const method = resolveUpdateMethod(ompPath, bunBinDir);
if (method === "bun") return { method };
return { method, path: ompPath };
}
if (bunBinDir) return { method: "bun" };
throw new Error(`Could not resolve ${APP_NAME} binary path in PATH`);
}
/**