From 5ee47126381ce79dced1e57e52df88d9d12e1602 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1rton=20Dan=C3=B3czy?= Date: Thu, 30 Jul 2026 13:42:26 +0200 Subject: [PATCH] =?UTF-8?q?docs:=20addressed=20PR=20#7079=20review=20?= =?UTF-8?q?=E2=80=94=20changelog=20entry=20+=20stale=20editor-stub=20note?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Added the coding-agent changelog entry the review flagged as missing. - Updated docs/extensions.md: the ACP UI-context surface note still listed editor among the stubbed no-op methods after it was wired through elicitFromAcpClient. --- docs/extensions.md | 2 +- packages/coding-agent/CHANGELOG.md | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/extensions.md b/docs/extensions.md index 33c0af111..5bbe0e5ab 100644 --- a/docs/extensions.md +++ b/docs/extensions.md @@ -391,7 +391,7 @@ When no UI context is supplied to runner init, `ctx.hasUI` is `false` and method ### ACP mode -ACP installs an elicitation-bridged UI context (`createAcpExtensionUiContext` in `acp-agent.ts`). `ctx.hasUI` is `true` while only `select`/`confirm`/`input` round-trip (as ACP elicitations; defaults are returned when the client lacks the `elicitation.form` capability). The non-elicitation surface (widgets, editor, theming, terminal input, autocomplete stacking) is stubbed no-op. +ACP installs an elicitation-bridged UI context (`createAcpExtensionUiContext` in `acp-agent.ts`). `ctx.hasUI` is `true` while `select`/`confirm`/`input`/`editor` round-trip (as ACP elicitations; defaults are returned when the client lacks the `elicitation.form` capability). The non-elicitation surface (widgets, theming, terminal input, autocomplete stacking) is stubbed no-op. ## Session and state patterns diff --git a/packages/coding-agent/CHANGELOG.md b/packages/coding-agent/CHANGELOG.md index 25c809467..4d59a90e7 100644 --- a/packages/coding-agent/CHANGELOG.md +++ b/packages/coding-agent/CHANGELOG.md @@ -19,6 +19,9 @@ - Fixed remote or LAN local-engine endpoints being ignored during model discovery: the llama.cpp and Ollama probes used timeouts tuned for loopback, so a host reached over the network could exceed them and return no models, while changing `OLLAMA_BASE_URL`/`OLLAMA_HOST` could keep reusing a fresh cache from the previous endpoint. Non-loopback hosts now get a generous discovery timeout, and Ollama cache rows are scoped to the normalized endpoint ([#7087](https://github.com/can1357/oh-my-pi/issues/7087)). - Fixed `omp install` failing extension validation for pi extensions that import `createEditTool` or `createWriteTool` (e.g. gentle-pi) — the legacy `@oh-my-pi/pi-coding-agent` shim exported the read/bash/grep/find/ls tool factories but omitted the edit and write ones, so a named import threw Bun's static "Export named X not found" error. Added `createEditTool`/`createEditToolDefinition` and `createWriteTool`/`createWriteToolDefinition` to match the upstream pi surface ([#7094](https://github.com/can1357/oh-my-pi/issues/7094)). - Fixed Python eval's loopback tool bridge being routed through macOS system HTTP proxies, which caused `parallel()` tool reads to fail with `ConnectionRefusedError` after a local proxy stopped. +### Fixed + +- Fixed `ctx.ui.editor()` in ACP mode always resolving to `undefined`: it now routes through the same elicitation bridge as `select`/`confirm`/`input`, so `/review`'s custom-instructions prompt and the `ask` tool's custom-input path reach the ACP client instead of silently no-opping. ## [17.2.0] - 2026-07-30