smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: wire classifyInstallTarget into handleInstall

Browse Source 
Route marketplace install targets (name@marketplace) to
MarketplaceManager.installPlugin() instead of npm install.
classifyInstallTarget() was implemented but never called from
the install handler.
This commit is contained in:
Miroslav Drbal
2026-03-30 13:44:53 +02:00
committed by can1357
parent 505b671c77
commit 5bf8e4ca92
1 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/src/cli/plugin-cli.ts
+28 -4
View File
@@ -121,7 +121,9 @@ export function parsePluginArgs(args: string[]): PluginCommandArgs | undefined {
return result;
}
export { classifyInstallTarget } from "./classify-install-target.js";
import { classifyInstallTarget } from "./classify-install-target";
export { classifyInstallTarget } from "./classify-install-target";
// =============================================================================
// Command Handlers
@@ -320,13 +322,35 @@ async function handleInstall(
console.error(chalk.red(`Usage: ${APP_NAME} plugin install <package[@version]>[features] ...`));
console.error(chalk.dim("Examples:"));
console.error(chalk.dim(` ${APP_NAME} plugin install @oh-my-pi/exa`));
console.error(chalk.dim(` ${APP_NAME} plugin install @oh-my-pi/exa[search,websets]`));
console.error(chalk.dim(` ${APP_NAME} plugin install @oh-my-pi/exa[*] # all features`));
console.error(chalk.dim(` ${APP_NAME} plugin install @oh-my-pi/exa[] # no optional features`));
console.error(chalk.dim(` ${APP_NAME} plugin install name@marketplace`));
process.exit(1);
}
// Build known marketplace set for classification
const mktMgr = makeMarketplaceManager();
const knownMarketplaces = new Set((await mktMgr.listMarketplaces()).map(m => m.name));
for (const spec of packages) {
const target = classifyInstallTarget(spec, knownMarketplaces);
if (target.type === "marketplace") {
try {
const entry = await mktMgr.installPlugin(target.name, target.marketplace, {
force: flags.force,
});
console.log(
chalk.green(
`${theme.status.success} Installed ${target.name} from ${target.marketplace} (${entry.version})`,
),
);
} catch (err) {
console.error(chalk.red(`${theme.status.error} Failed to install ${spec}: ${err}`));
process.exit(1);
}
continue;
}
// npm path
try {
const result = await manager.install(spec, { force: flags.force, dryRun: flags.dryRun });