smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(coding-agent/task): fixed task glyphs for running, pending, and completed progress

Browse Source 
- Updated task call and result headers to use the dispatch glyph during running async calls instead of spinner-style states.
- Switched running and pending agent rows to a static done-dot marker and reused the dot with foreground color settling when rows complete.
- Updated task rendering tests to validate the new glyphs and ensure running/pending rows do not emit spinner or pending symbols.
This commit is contained in:
can1357
2026-06-12 04:58:21 +02:00
parent 228d536a36
commit 4f0360e77a
4 changed files with 89 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/src/task/render.ts
+33 -18
View File
@@ -627,7 +627,13 @@ function createMarkdownSectionRenderer(text: string, theme: Theme): AssignmentSe
*/
export function renderCall(args: TaskParams, options: TaskRenderOptions, theme: Theme): Component {
const showIsolated = "isolated" in args && args.isolated === true;
const header = renderStatusLine({ icon: "pending", title: "Task", description: args.agent }, theme);
// Dispatch glyph from the first frame: spawning is non-blocking, so a
// pending/hourglass icon would misread the call as something the turn
// waits on.
const header = renderStatusLine(
{ iconOverride: theme.styledSymbol("tool.task", "accent"), title: "Task", description: args.agent },
theme,
);
const assignmentSection = createAssignmentSectionRenderer(args, theme);
const contextSection = createContextSectionRenderer(args, theme);
return framedBlock(theme, width => {
@@ -692,21 +698,23 @@ function renderAgentProgress(
const indent = prefix ? `${prefix} ` : "";
let statusLine: string;
if (progress.status === "running" || progress.status === "pending") {
// Live (or queued) agents use the task icon: detached async spawns can
// stay "pending" while real work is running, so a pending/hourglass glyph
// reads wrong in the transcript. Keep the row static; the Task tool header
// already carries any live animation.
const taskIcon = theme.styledSymbol("tool.task", frozen ? "dim" : "accent");
// Live (or queued) agents use the same dot finished rows keep: detached
// async spawns can stay "pending" while real work is running, so a
// pending/hourglass or spinner glyph reads wrong in the transcript. Keep
// the row static; the Task tool header already carries the dispatch icon.
const dot = theme.styledSymbol("status.done", frozen ? "dim" : "accent");
const nameColor = frozen ? "dim" : "accent";
const name = theme.fg(nameColor, description ? theme.bold(displayId) : displayId);
statusLine = `${indent}${taskIcon} ${name}`;
statusLine = `${indent}${dot} ${name}`;
if (description) {
statusLine += `${theme.fg(nameColor, ":")} ${theme.fg(nameColor, description)}`;
}
} else if (progress.status === "completed") {
// Finished rows keep the dot but settle from accent to the plain
// foreground: completion reads as a color change, not a new glyph.
statusLine = `${indent}${theme.styledSymbol("status.done", "text")} ${theme.fg("text", titlePart)}`;
} else {
const glyph =
progress.status === "completed" ? theme.styledSymbol("status.done", "accent") : theme.fg(iconColor, icon);
statusLine = `${indent}${glyph} ${theme.fg("accent", titlePart)}`;
statusLine = `${indent}${theme.fg(iconColor, icon)} ${theme.fg("accent", titlePart)}`;
}
// Show retry-blocked badge so the parent immediately sees that a child
@@ -982,7 +990,7 @@ function renderAgentResult(
: needsWarning
? theme.status.warning
: success
? theme.styledSymbol("status.done", "accent")
? theme.styledSymbol("status.done", "text")
: theme.status.error;
const iconColor = needsWarning ? "warning" : success ? "success" : mergeFailed ? "warning" : "error";
const statusText = aborted
@@ -999,11 +1007,10 @@ function renderAgentResult(
const description = result.description?.trim();
const displayId = formatTaskId(result.id);
const titlePart = description ? `${theme.bold(displayId)}: ${description}` : displayId;
let statusLine = `${prefix ? `${prefix} ` : ""}${theme.fg(iconColor, icon)} ${theme.fg("accent", titlePart)} ${formatBadge(
statusText,
iconColor,
theme,
)}`;
let statusLine = `${prefix ? `${prefix} ` : ""}${theme.fg(iconColor, icon)} ${theme.fg(
success && !needsWarning ? "text" : "accent",
titlePart,
)} ${formatBadge(statusText, iconColor, theme)}`;
const showBadge = settings.get("task.showResolvedModelBadge");
statusLine = appendAgentStats(
statusLine,
@@ -1217,8 +1224,16 @@ export function renderResult(
const metaLabel = countLabel ? (agentLabel ? `${countLabel}: ${agentLabel}` : countLabel) : agentLabel;
const header = renderStatusLine(
{
icon: icon === "success" ? undefined : icon,
iconOverride: icon === "success" ? theme.styledSymbol("status.done", "accent") : undefined,
icon: icon === "success" || icon === "running" ? undefined : icon,
// While agents are in flight the header shows the dispatch glyph, not a
// spinner: async spawns return immediately, so "running" means
// "delegated to peers", not "this call is blocking the turn".
iconOverride:
icon === "running"
? theme.styledSymbol("tool.task", "accent")
: icon === "success"
? theme.styledSymbol("status.done", "accent")
: undefined,
title: "Task",
meta: metaLabel ? [metaLabel] : undefined,
},