feat(irc): proactive coordination suggestions

When one task call spawns two or more live siblings with spawn capacity and IRC enabled, TaskTool.execute appends a coordinate-via-irc suggestion, composed onto the specialization advisory through the same seam. Tighten the subagent COOP section and irc tool prompt so guidance spans discovery (list who/what), coordination (message before overlapping edits), and follow-up (replyTo/await) instead of only assuming agents resolve collisions on their own. Refs #2471 Op: extend
2026-06-14 05:02:00 +09:00
parent aeebcbb6c2
commit 3cd5fd79c2
6 changed files with 263 additions and 14 deletions
@@ -1,6 +1,12 @@
-import { describe, expect, it } from "bun:test";
-import { buildSpecializationAdvisory } from "@oh-my-pi/pi-coding-agent/task";
-import type { TaskItem } from "@oh-my-pi/pi-coding-agent/task/types";
+import { afterEach, beforeEach, describe, expect, it, vi } from "bun:test";
+import { Settings } from "@oh-my-pi/pi-coding-agent/config/settings";
+import { AgentLifecycleManager } from "@oh-my-pi/pi-coding-agent/registry/agent-lifecycle";
+import { AgentRegistry } from "@oh-my-pi/pi-coding-agent/registry/agent-registry";
+import { buildSpecializationAdvisory, TaskTool } from "@oh-my-pi/pi-coding-agent/task";
+import * as discoveryModule from "@oh-my-pi/pi-coding-agent/task/discovery";
+import * as executorModule from "@oh-my-pi/pi-coding-agent/task/executor";
+import type { AgentDefinition, SingleResult, TaskItem, TaskParams } from "@oh-my-pi/pi-coding-agent/task/types";
+import type { ToolSession } from "@oh-my-pi/pi-coding-agent/tools";

 // Contract: the task tool appends an advisory (never a rejection) steering the
 // spawner toward tailored specialists when it spawns generic role-less workers
@@ -36,3 +42,70 @@ describe("buildSpecializationAdvisory", () => {
 		expect(buildSpecializationAdvisory("reviewer", [item()], true)).toBeUndefined();
 	});
 });
+
+// Contract: the advisory rides the task-tool result for an interactive spawner,
+// but a session that opts out (`suppressSpawnAdvisory` — internal/programmatic
+// callers like the commit agent's file-analysis fan-out) gets a clean result so
+// the nudge never contaminates code-consumed evidence.
+describe("task tool advisory gating via suppressSpawnAdvisory", () => {
+	const agent: AgentDefinition = {
+		name: "task",
+		description: "General-purpose task agent",
+		systemPrompt: "You are a task agent.",
+		source: "bundled",
+	};
+
+	beforeEach(() => {
+		AgentRegistry.resetGlobalForTests();
+		AgentLifecycleManager.resetGlobalForTests();
+	});
+
+	afterEach(() => {
+		vi.restoreAllMocks();
+		AgentLifecycleManager.resetGlobalForTests();
+		AgentRegistry.resetGlobalForTests();
+	});
+
+	function session(suppress: boolean): ToolSession {
+		return {
+			cwd: "/tmp",
+			hasUI: false,
+			suppressSpawnAdvisory: suppress,
+			settings: Settings.isolated({ "task.isolation.mode": "none", "task.batch": false }),
+			getSessionFile: () => null,
+			getSessionSpawns: () => "*",
+		} as unknown as ToolSession;
+	}
+
+	async function spawnText(suppress: boolean): Promise<string> {
+		vi.spyOn(discoveryModule, "discoverAgents").mockResolvedValue({ agents: [agent], projectAgentsDir: null });
+		vi.spyOn(executorModule, "runSubprocess").mockImplementation(
+			async (options): Promise<SingleResult> => ({
+				index: 0,
+				id: options.id ?? "X",
+				agent: "task",
+				agentSource: "bundled",
+				task: "t",
+				assignment: "do the thing",
+				exitCode: 0,
+				output: "done",
+				stderr: "",
+				truncated: false,
+				durationMs: 1,
+				tokens: 0,
+				requests: 1,
+			}),
+		);
+		const tool = await TaskTool.create(session(suppress));
+		const result = await tool.execute("tc", { agent: "task", id: "X", assignment: "do the thing" } as TaskParams);
+		return result.content.find(part => part.type === "text")?.text ?? "";
+	}
+
+	it("appends the specialization advisory for a generic role-less spawn", async () => {
+		expect(await spawnText(false)).toContain("`role`");
+	});
+
+	it("omits the advisory entirely when the session suppresses it", async () => {
+		expect(await spawnText(true)).not.toContain("`role`");
+	});
+});