fix(robomp): route issues.reopened to admission-gated re-triage

The finalized-issue boilerplate promises "reopen and I'll triage again from
scratch," but github_events.route() dropped issues.reopened to the ignored
skip branch (only opened/closed handled), while pull_request.reopened was
already routed. A user following the instruction got silence.

Route issues.reopened like issues.opened (submitter-attributable triage_issue,
same per-user rate budget) and dispatch it in queue._dispatch(). triage_issue
now tears down a stale finalized workspace (merged/closed/abandoned) before
re-provisioning, mirroring the maintainer directive-reopen teardown so the
re-triage branches afresh from default instead of a merged/deleted branch.

Fixes #5891
This commit is contained in:
roboomp
2026-07-23 19:18:48 +00:00
parent c64e7146e0
commit 3967ad0d5d
5 changed files with 103 additions and 4 deletions
+5 -2
View File
@@ -300,10 +300,13 @@ def route(
if not isinstance(number, int):
return RouteDecision("skip", None, repo, None, "issue missing number")
key = issue_key(repo, number)
if action == "opened":
if action in ("opened", "reopened"):
# A reopen is submitter-attributable exactly like an open, and
# `finalized_issue_comment.md` promises re-triage on reopen, so it
# re-triages from scratch and spends the same per-user rate budget.
login, assoc = _submitter_info(issue)
return RouteDecision(
"queue", "triage_issue", repo, key, "issues.opened", submitter=login, association=assoc
"queue", "triage_issue", repo, key, f"issues.{action}", submitter=login, association=assoc
)
if action == "closed":
# Cleanup is a lifecycle event, not a user submission; no rate-limit subject.
+1 -1
View File
@@ -382,7 +382,7 @@ class WorkerPool:
"recovered": row.attempts >= 2,
},
)
if event == "issues" and action == "opened":
if event == "issues" and action in ("opened", "reopened"):
await tasks.triage_issue(
settings=self.settings,
db=self.db,
+8 -1
View File
@@ -282,7 +282,8 @@ async def triage_issue(
log.info("skip: triage on PR-like issue", extra={"repo": repo.full_name, "n": issue.number})
return
key = issue_key(repo.full_name, issue.number)
if db.get_issue(key) is None:
existing = db.get_issue(key)
if existing is None:
# First-time triage: bail if a PR (human or another bot) already
# claims to close this issue via Closes/Fixes/Resolves syntax or
# the Development panel. We never replay closing-PR detection on
@@ -304,6 +305,12 @@ async def triage_issue(
extra={"key": key, "prs": list(closing_prs)},
)
return
elif existing.state in ("merged", "closed", "abandoned"):
# Reopen of a finalized issue (issues.reopened): the prior branch is
# stale (merged/deleted), so tear the workspace down and branch afresh
# from default — the same teardown the maintainer directive-reopen uses.
log.info("reopen re-triage", extra={"key": key, "from_state": existing.state})
await _run_workspace_op(sandbox.remove_workspace, repo=repo.full_name, number=issue.number)
db.upsert_issue(key=key, repo=repo.full_name, number=issue.number, state="reproducing")
clone_url = repo.clone_url
workspace = await _run_workspace_op(