From 366313df33cfb4913816955e87dcc705b635c5fc Mon Sep 17 00:00:00 2001 From: can1357 Date: Thu, 25 Jun 2026 05:15:40 +0200 Subject: [PATCH] test(coding-agent): improved stdout geometry stubs in tests - Added no-op setters to process.stdout properties in test geometry stubs. - Prevented potential errors when code under test attempts to reassign stdout dimensions. --- .../coding-agent/test/agent-dashboard-create-editor.test.ts | 4 ++-- packages/coding-agent/test/agent-hub-advisor-scroll.test.ts | 2 +- packages/coding-agent/test/agent-hub-ordering.test.ts | 4 ++-- .../modes/components/settings-selector-memory-refresh.test.ts | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/coding-agent/test/agent-dashboard-create-editor.test.ts b/packages/coding-agent/test/agent-dashboard-create-editor.test.ts index 8569492c8..d23745a9a 100644 --- a/packages/coding-agent/test/agent-dashboard-create-editor.test.ts +++ b/packages/coding-agent/test/agent-dashboard-create-editor.test.ts @@ -36,8 +36,8 @@ function stubStdoutGeometry(cols: number): { setRows(n: number): void; restore() const rowsDesc = Object.getOwnPropertyDescriptor(process.stdout, "rows"); const colsDesc = Object.getOwnPropertyDescriptor(process.stdout, "columns"); let rows = 24; - Object.defineProperty(process.stdout, "rows", { configurable: true, get: () => rows }); - Object.defineProperty(process.stdout, "columns", { configurable: true, get: () => cols }); + Object.defineProperty(process.stdout, "rows", { configurable: true, get: () => rows, set: () => {} }); + Object.defineProperty(process.stdout, "columns", { configurable: true, get: () => cols, set: () => {} }); const restoreOne = (key: "rows" | "columns", desc: PropertyDescriptor | undefined) => { if (desc) Object.defineProperty(process.stdout, key, desc); else Object.defineProperty(process.stdout, key, { configurable: true, value: undefined, writable: true }); diff --git a/packages/coding-agent/test/agent-hub-advisor-scroll.test.ts b/packages/coding-agent/test/agent-hub-advisor-scroll.test.ts index cf39f0d84..ea00815e8 100644 --- a/packages/coding-agent/test/agent-hub-advisor-scroll.test.ts +++ b/packages/coding-agent/test/agent-hub-advisor-scroll.test.ts @@ -123,7 +123,7 @@ describe("AgentTranscriptViewer", () => { await Settings.init({ inMemory: true }); initTheme(); rowsDesc = Object.getOwnPropertyDescriptor(process.stdout, "rows"); - Object.defineProperty(process.stdout, "rows", { configurable: true, get: () => 24 }); + Object.defineProperty(process.stdout, "rows", { configurable: true, get: () => 24, set: () => {} }); }); afterEach(() => { diff --git a/packages/coding-agent/test/agent-hub-ordering.test.ts b/packages/coding-agent/test/agent-hub-ordering.test.ts index 8f1d1c7ee..e6cbcc2da 100644 --- a/packages/coding-agent/test/agent-hub-ordering.test.ts +++ b/packages/coding-agent/test/agent-hub-ordering.test.ts @@ -23,8 +23,8 @@ function stubStdoutGeometry(cols: number): GeometryStub { const rowsDesc = Object.getOwnPropertyDescriptor(process.stdout, "rows"); const colsDesc = Object.getOwnPropertyDescriptor(process.stdout, "columns"); let rows = 24; - Object.defineProperty(process.stdout, "rows", { configurable: true, get: () => rows }); - Object.defineProperty(process.stdout, "columns", { configurable: true, get: () => cols }); + Object.defineProperty(process.stdout, "rows", { configurable: true, get: () => rows, set: () => {} }); + Object.defineProperty(process.stdout, "columns", { configurable: true, get: () => cols, set: () => {} }); const restoreOne = (key: "rows" | "columns", desc: PropertyDescriptor | undefined) => { if (desc) Object.defineProperty(process.stdout, key, desc); else Object.defineProperty(process.stdout, key, { configurable: true, value: undefined, writable: true }); diff --git a/packages/coding-agent/test/modes/components/settings-selector-memory-refresh.test.ts b/packages/coding-agent/test/modes/components/settings-selector-memory-refresh.test.ts index 369a072c9..3e1bd8aa6 100644 --- a/packages/coding-agent/test/modes/components/settings-selector-memory-refresh.test.ts +++ b/packages/coding-agent/test/modes/components/settings-selector-memory-refresh.test.ts @@ -25,8 +25,8 @@ function stubStdoutGeometry(cols: number): { restore(): void } { const rowsDesc = Object.getOwnPropertyDescriptor(process.stdout, "rows"); const colsDesc = Object.getOwnPropertyDescriptor(process.stdout, "columns"); const rows = 40; - Object.defineProperty(process.stdout, "rows", { configurable: true, get: () => rows }); - Object.defineProperty(process.stdout, "columns", { configurable: true, get: () => cols }); + Object.defineProperty(process.stdout, "rows", { configurable: true, get: () => rows, set: () => {} }); + Object.defineProperty(process.stdout, "columns", { configurable: true, get: () => cols, set: () => {} }); const restoreOne = (key: "rows" | "columns", desc: PropertyDescriptor | undefined) => { if (desc) Object.defineProperty(process.stdout, key, desc); else Object.defineProperty(process.stdout, key, { configurable: true, value: undefined, writable: true });