fix(task): guard deferred launch work

packages/coding-agent/test/task/executor-launch-startup.test.ts

@@ -0,0 +1,103 @@
+import { afterEach, expect, it, vi } from "bun:test";
+import { AuthStorage } from "@oh-my-pi/pi-ai";
+import { ModelRegistry } from "@oh-my-pi/pi-coding-agent/config/model-registry";
+import type { CreateAgentSessionResult } from "@oh-my-pi/pi-coding-agent/sdk";
+import * as sdkModule from "@oh-my-pi/pi-coding-agent/sdk";
+import type { AgentSession, AgentSessionEvent } from "@oh-my-pi/pi-coding-agent/session/agent-session";
+import { SessionManager } from "@oh-my-pi/pi-coding-agent/session/session-manager";
+import { runSubprocess } from "@oh-my-pi/pi-coding-agent/task/executor";
+import { EventBus } from "@oh-my-pi/pi-coding-agent/utils/event-bus";
+import { TempDir } from "@oh-my-pi/pi-utils";
+
+const authStorages: AuthStorage[] = [];
+const tempDirs: TempDir[] = [];
+
+afterEach(async () => {
+	vi.restoreAllMocks();
+	for (const authStorage of authStorages.splice(0)) await authStorage.close();
+	for (const tempDir of tempDirs.splice(0)) tempDir[Symbol.dispose]();
+});
+
+it("overlaps registry refresh with session-file opening and session setup", async () => {
+	const tempDir = TempDir.createSync("@pi-task-launch-");
+	tempDirs.push(tempDir);
+	const authStorage = await AuthStorage.create(tempDir.join("auth.db"));
+	authStorages.push(authStorage);
+
+	const refreshGate = Promise.withResolvers<void>();
+	vi.spyOn(ModelRegistry.prototype, "refresh").mockImplementation(() => refreshGate.promise);
+
+	const sessionManager = SessionManager.inMemory(tempDir.path());
+	const openGate = Promise.withResolvers<SessionManager>();
+	const openStarted = Promise.withResolvers<void>();
+	const openSpy = vi.spyOn(SessionManager, "open").mockImplementation(() => {
+		openStarted.resolve();
+		return openGate.promise;
+	});
+
+	const sessionCreationStarted = Promise.withResolvers<void>();
+	let sessionCreated = false;
+	const listeners: Array<(event: AgentSessionEvent) => void> = [];
+	const session = {
+		state: { messages: [] },
+		agent: { state: { systemPrompt: ["test"] } },
+		model: undefined,
+		extensionRunner: undefined,
+		sessionManager: { appendSessionInit: () => {} },
+		getActiveToolNames: () => ["yield"],
+		getEnabledToolNames: () => ["yield"],
+		setActiveToolsByName: async () => {},
+		subscribe: (listener: (event: AgentSessionEvent) => void) => {
+			listeners.push(listener);
+			return () => {};
+		},
+		prompt: async () => {
+			for (const listener of listeners) {
+				listener({
+					type: "tool_execution_end",
+					toolCallId: "yield",
+					toolName: "yield",
+					result: { content: [], details: { status: "success", data: { ok: true } } },
+					isError: false,
+				} as AgentSessionEvent);
+			}
+		},
+		waitForIdle: async () => {},
+		getLastAssistantMessage: () => undefined,
+		abort: async () => {},
+		dispose: async () => {},
+	} as unknown as AgentSession;
+	vi.spyOn(sdkModule, "createAgentSession").mockImplementation(async () => {
+		sessionCreationStarted.resolve();
+		sessionCreated = true;
+		return {
+			session,
+			extensionsResult: {},
+			setToolUIContext: () => {},
+			eventBus: new EventBus(),
+		} as CreateAgentSessionResult;
+	});
+
+	const run = runSubprocess({
+		cwd: tempDir.path(),
+		artifactsDir: tempDir.path(),
+		agent: { name: "task", description: "test", systemPrompt: "test", source: "bundled" },
+		task: "test",
+		index: 0,
+		id: "task-launch-overlap",
+		authStorage,
+		enableLsp: false,
+		enableIrc: false,
+	});
+	await openStarted.promise;
+
+	expect(openSpy).toHaveBeenCalledTimes(1);
+	expect(sessionCreated).toBe(false);
+
+	openGate.resolve(sessionManager);
+	await sessionCreationStarted.promise;
+	expect(sessionCreated).toBe(true);
+
+	refreshGate.resolve();
+	expect((await run).exitCode).toBe(0);
+});

packages/coding-agent/test/task/executor-prewalk.test.ts

@@ -96,6 +96,7 @@ function createModelRegistry(models: Model[]): ModelRegistry {
 	return {
 		authStorage: {},
 		refresh: async () => {},
+		awaitBackgroundRefresh: async () => {},
 		getAvailable: () => models,
 		getApiKey: async () => "test-key",
 		hasConfiguredAuth: () => true,
@@ -149,6 +150,34 @@ describe("runSubprocess per-agent prewalk", () => {
 		expect(forwarded?.prewalk?.target.provider).toBe(target.provider);
 	});
 
+	it("waits for background discovery before resolving a configured prewalk target", async () => {
+		const models = [primary];
+		const registry = createModelRegistry(models);
+		const refreshGate = Promise.withResolvers<void>();
+		vi.spyOn(registry, "awaitBackgroundRefresh").mockImplementation(async () => {
+			await refreshGate.promise;
+			models.push(target);
+		});
+		const spy = vi
+			.spyOn(sdkModule, "createAgentSession")
+			.mockResolvedValue(createSessionResult(yieldEmittingSession()));
+
+		const run = runSubprocess({
+			...baseOptions("subagent-prewalk-discovery", Settings.isolated()),
+			modelRegistry: registry,
+			agent: {
+				...baseAgent,
+				model: [`${primary.provider}/${primary.id}`],
+				prewalk: `${target.provider}/${target.id}`,
+			},
+		});
+		expect(spy).not.toHaveBeenCalled();
+
+		refreshGate.resolve();
+		expect((await run).exitCode).toBe(0);
+		expect(spy.mock.calls[0]?.[0]?.prewalk?.target.id).toBe(target.id);
+	});
+
 	it("reports the prewalk target as the active model after handoff", async () => {
 		const progressModels: string[] = [];
 		vi.spyOn(sdkModule, "createAgentSession").mockResolvedValue(