smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: normalize backslashes in all POSIX path components for profile-alias

Browse Source 
Address codex review feedback on PR #3346:
- path.posix.join only adds / separators but preserves existing backslashes
  in input segments (homeDir, ZDOTDIR, XDG_CONFIG_HOME), producing mixed
  paths like C:\Users\me/.bashrc on Windows.
- Add toPosix() helper to normalize backslashes to forward slashes before
  path.posix.join, applied to all POSIX-shell path components.
- PowerShell paths remain platform-native (path.join) as before.
- Add 3 regression tests: bash homeDir, zsh ZDOTDIR, fish XDG_CONFIG_HOME
  all with Windows backslash paths.
This commit is contained in:
oldschoola
2026-06-23 13:55:51 -07:00
parent 8afedab04a
commit 2ce25f2dc2
2 changed files with 77 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/src/cli/profile-alias.ts
+16 -5
View File
@@ -211,6 +211,13 @@ export function resolveProfileAliasCommandFromProcess(
};
}
/** Normalize backslashes to forward slashes for POSIX-shell paths.
* path.posix.join only adds / separators — it preserves existing backslashes
* in input segments like homeDir ("C:\Users\me"), producing mixed paths. */
function toPosix(p: string): string {
return p.replace(/\\/g, "/");
}
function resolveShellConfigPath(
shell: ProfileAliasShell,
homeDir: string,
@@ -218,25 +225,29 @@ function resolveShellConfigPath(
env: NodeJS.ProcessEnv,
): string {
// POSIX shells (bash/zsh/fish) always need forward-slash config paths,
// even on Windows — path.posix.join guarantees that regardless of platform.
// even on Windows. path.posix.join adds / separators but preserves existing
// backslashes in input segments, so we normalize each component with toPosix.
// PowerShell profiles use the platform-native path.join (backslashes on
// Windows, forward slashes elsewhere).
const posixHome = toPosix(homeDir);
switch (shell) {
case "zsh":
return path.posix.join(env.ZDOTDIR || homeDir, ".zshrc");
return path.posix.join(env.ZDOTDIR ? toPosix(env.ZDOTDIR) : posixHome, ".zshrc");
case "bash":
return platform === "darwin" ? path.posix.join(homeDir, ".bash_profile") : path.posix.join(homeDir, ".bashrc");
return platform === "darwin"
? path.posix.join(posixHome, ".bash_profile")
: path.posix.join(posixHome, ".bashrc");
case "fish": {
// fish sources conf.d from $XDG_CONFIG_HOME/fish (default ~/.config/fish);
// a hard-coded ~/.config would be silently ignored when the user relocates
// their XDG config root, leaving the alias unsourced after a restart.
const configHome = env.XDG_CONFIG_HOME || path.posix.join(homeDir, ".config");
const configHome = env.XDG_CONFIG_HOME ? toPosix(env.XDG_CONFIG_HOME) : path.posix.join(posixHome, ".config");
return path.posix.join(configHome, "fish", "conf.d", "omp-profiles.fish");
}
case "pwsh":
return platform === "win32"
? path.join(homeDir, "Documents", "PowerShell", "Microsoft.PowerShell_profile.ps1")
: path.posix.join(homeDir, ".config", "powershell", "Microsoft.PowerShell_profile.ps1");
: path.posix.join(posixHome, ".config", "powershell", "Microsoft.PowerShell_profile.ps1");
case "powershell":
return path.join(homeDir, "Documents", "WindowsPowerShell", "Microsoft.PowerShell_profile.ps1");
}