fix(coding-agent): stop ESC from aborting agent run while @ autocomplete is open

When the autocomplete popup is visible, ESC unconditionally falls through
to the editor base class so it can dismiss the popup. Only an ESC with no
popup visible reaches onEscape and routes to the global interrupt handler.

Removed the shouldBypassAutocompleteOnEscape callback that paved over the
popup-dismissal path whenever the agent was busy (streaming, bash, /btw,
auto-compaction, etc.) — that is precisely the moment the user is most
likely to hit ESC while the popup is open, and dismissing-then-aborting in
one keystroke is a footgun, not a feature. Two-press semantics now match
the standard TUI/IDE pattern: first ESC closes the popup, second ESC
aborts.

Tests cover both branches in custom-editor-keybindings.test.ts and the
input-controller escape suite no longer asserts the dead callback.

Fixes #1655

This commit is contained in:

roboomp

2026-06-01 17:26:10 +00:00

parent fbdc064186

commit 27f4965e00

6 changed files with 51 additions and 28 deletions

									
										packages/coding-agent/test/input-controller-keybindings.test.ts
									
		-1
	
												View File
												
				@@ -4,7 +4,6 @@ import type { InteractiveModeContext } from "../src/modes/types";

				type FakeEditor = {

					onEscape?: () => void;

					shouldBypassAutocompleteOnEscape?: () => boolean;

					onClear?: () => void;

					onExit?: () => void;

					onSuspend?: () => void;