smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf(commit): reuse split diff parser

Browse Source
This commit is contained in:
can1357
2026-06-08 15:17:38 -03:00
parent 22b152e220
commit 243ad581e6
2 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/src/commit/agentic/tools/split-commit.ts
+4 -3
View File
@@ -68,6 +68,7 @@ export function createSplitCommitTool(
const errors: string[] = [];
const warnings: string[] = [];
const diffText = await git.diff(cwd, { cached: true });
const validateHunksForDiff = git.createHunkSelectionValidator(diffText);
const commits: SplitCommitGroup[] = params.commits.map((commit, index) => {
const scope = commit.scope?.trim() || null;
@@ -102,7 +103,7 @@ export function createSplitCommitTool(
}
warnings.push(...summaryValidation.warnings.map(warning => `Commit ${index + 1}: ${warning}`));
warnings.push(...typeValidation.warnings.map(warning => `Commit ${index + 1}: ${warning}`));
const hunkValidation = validateHunkSelectors(index, changes, files, diffText);
const hunkValidation = validateHunkSelectors(index, changes, files, validateHunksForDiff);
warnings.push(...hunkValidation.warnings);
errors.push(...hunkValidation.errors);
errors.push(...validateDependencies(index, dependencies, params.commits.length));
@@ -186,7 +187,7 @@ function validateHunkSelectors(
commitIndex: number,
changes: SplitCommitGroup["changes"],
files: string[],
diffText: string,
validateHunksForDiff: (changes: SplitCommitGroup["changes"]) => git.HunkSelectionValidationError[],
): { errors: string[]; warnings: string[] } {
const errors: string[] = [];
const warnings: string[] = [];
@@ -217,7 +218,7 @@ function validateHunkSelectors(
}
}
if (errors.length === 0) {
for (const error of git.validateHunkSelections(diffText, changes)) {
for (const error of validateHunksForDiff(changes)) {
errors.push(`${prefix}: ${error.message}`);
}
}