From 2290941e00ab36b37a2b5addb3dc02b21c06c089 Mon Sep 17 00:00:00 2001 From: can1357 Date: Tue, 26 May 2026 22:53:30 +0200 Subject: [PATCH] fix(coding-agent): fixed handoff test to resolve concrete handoff strings - Adjusted handoff test Promise resolver typings to use non-undefined string values. - Updated the mocked generateHandoff promise to resolve with a string handoff value. - Resolved the pending handoff promise with "handoff" in test cleanup to satisfy the contract. --- packages/coding-agent/test/agent-session-handoff.test.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/coding-agent/test/agent-session-handoff.test.ts b/packages/coding-agent/test/agent-session-handoff.test.ts index b3a970bd5..008d0dc4c 100644 --- a/packages/coding-agent/test/agent-session-handoff.test.ts +++ b/packages/coding-agent/test/agent-session-handoff.test.ts @@ -497,12 +497,13 @@ describe("AgentSession handoff", () => { throw new Error("Expected model to be set"); } - const { promise: handoffPending, resolve: resolveHandoff } = Promise.withResolvers(); + const { promise: handoffPending, resolve: resolveHandoff } = Promise.withResolvers(); + const generateHandoffSpy = vi .spyOn(compactionModule, "generateHandoff") .mockImplementation(async (_msgs, _model, _key, _opts, signal) => { // Mirror the real generateHandoff contract: reject when the caller aborts. - return await new Promise((resolve, reject) => { + return await new Promise((resolve, reject) => { signal?.addEventListener("abort", () => reject(new Error("Handoff cancelled")), { once: true }); handoffPending.then(resolve, reject); }); @@ -541,7 +542,7 @@ describe("AgentSession handoff", () => { await expect(disposed).resolves.toBe("disposed"); // Releasing after the fact must not leak into other tests. - resolveHandoff(undefined); + resolveHandoff("handoff"); }); it("falls back to context-full when handoff strategy returns no document", async () => {