smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge PR #8896: fix(settings): hide excluded search providers from summary (@poorpaper)

Browse Source
This commit is contained in:
can1357
2026-08-19 01:38:34 +02:00
parent 0ac4e01b7b 6862ac08f0
commit 22439b6be2
3 changed files with 46 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/src/modes/components/settings-selector.ts
+17 -11
View File
@@ -1168,15 +1168,15 @@ export class SettingsSelectorComponent implements Component {
return entries.map(([provider, limit]) => `${provider}: ${limit}`).join(", ");
}
#createMultiSelect(def: SettingDef & { type: "multiselect" }, done: (value?: string) => void): Container {
let options = def.options;
if (def.path === "providers.webSearchOrder") {
const excluded: unknown = settings.get("providers.webSearchExclude");
if (Array.isArray(excluded)) {
options = options.filter(option => !excluded.includes(option.value));
}
}
#getMultiSelectOptions(def: SettingDef & { type: "multiselect" }) {
if (def.path !== "providers.webSearchOrder") return def.options;
const excluded: unknown = settings.get("providers.webSearchExclude");
if (!Array.isArray(excluded)) return def.options;
return def.options.filter(option => !excluded.includes(option.value));
}
#createMultiSelect(def: SettingDef & { type: "multiselect" }, done: (value?: string) => void): Container {
const options = this.#getMultiSelectOptions(def);
const current: unknown = settings.get(def.path);
const initial = Array.isArray(current)
? current.filter((entry): entry is string => typeof entry === "string")
@@ -1196,9 +1196,15 @@ export class SettingsSelectorComponent implements Component {
}
#formatMultiSelectValue(def: SettingDef & { type: "multiselect" }, value: unknown): string {
const ids = Array.isArray(value) ? value.filter((entry): entry is string => typeof entry === "string") : [];
if (ids.length === 0) return def.ordered ? "default" : "none";
const labels = ids.map(id => def.options.find(option => option.value === id)?.label ?? id);
const options = this.#getMultiSelectOptions(def);
const labels = Array.isArray(value)
? value.flatMap(entry => {
if (typeof entry !== "string") return [];
const option = options.find(candidate => candidate.value === entry);
return option ? [option.label] : [];
})
: [];
if (labels.length === 0) return def.ordered ? "default" : "none";
return def.ordered ? labels.join(" → ") : labels.join(", ");
}