smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix ACP review follow-ups

Browse Source
This commit is contained in:
Ogrodev
2026-05-13 06:00:45 +02:00
committed by can1357
parent 9ae60cd793
commit 1a44cd2e36
4 changed files with 167 additions and 96 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/src/session/agent-session.ts
+9 -3
View File
@@ -515,6 +515,8 @@ const PERMISSION_OPTIONS: ClientBridgePermissionOption[] = [
{ optionId: "reject_always", name: "Always reject", kind: "reject_always" },
];
const PERMISSION_OPTIONS_BY_ID = new Map(PERMISSION_OPTIONS.map(option => [option.optionId, option]));
function derivePermissionTitle(toolName: string, args: unknown): string {
const a = args && typeof args === "object" ? (args as Record<string, unknown>) : {};
if (toolName === "bash") {
@@ -2691,12 +2693,16 @@ export class AgentSession {
if (outcome.outcome === "cancelled") {
throw new ToolAbortError("Permission request cancelled");
}
if (outcome.optionId === "allow_always") {
const selectedOption = PERMISSION_OPTIONS_BY_ID.get(outcome.optionId);
if (!selectedOption) {
throw new ToolError(`Tool permission response used unknown option ID: ${outcome.optionId}`);
}
if (selectedOption.kind === "allow_always") {
this.#acpPermissionDecisions.set(target.name, "allow_always");
} else if (outcome.optionId === "reject_always") {
} else if (selectedOption.kind === "reject_always") {
this.#acpPermissionDecisions.set(target.name, "reject_always");
}
if (outcome.optionId.startsWith("reject")) {
if (selectedOption.kind === "reject_once" || selectedOption.kind === "reject_always") {
throw new ToolError(`Tool call rejected by user (${target.name})`);
}
return await target.execute(toolCallId, args as never, signal, onUpdate, ctx);