From 167892048ea157273b25df2c7eaeb4ee9feaf41b Mon Sep 17 00:00:00 2001
From: Wolfgang Schoenberger <221313372+wolfiesch@users.noreply.github.com>
Date: Mon, 27 Jul 2026 01:42:06 -0700
Subject: [PATCH] test(coding-agent): decouple changelog bundle probe from
 native addon resolution

The "reads the emitted changelog asset when run outside the bundle directory"
probe built its bundle by shelling out to `bun build`, which cannot take a
plugin. The real `@oh-my-pi/pi-utils` and the changelog module's `../config`
import therefore stayed in the graph, and both pull in the native addon loader.
The emitted bundle called `loadNative()` at startup and resolved
`pi_natives.<platform>.node` relative to its own directory, but the probe is
written to a temp dir and run from an unrelated cwd, so that lookup cannot
succeed. Whether the test passed depended on a platform native happening to be
resolvable next to the runner.

Build it with `Bun.build()` and the same `changelog-utils-stub` plugin the
compiled-binary probe in this file already uses, extracted into one shared
helper. The subject under test is emitted-asset resolution, not native loading.
---
 .../utils/changelog-static-import.test.ts     | 57 ++++++++++---------
 1 file changed, 29 insertions(+), 28 deletions(-)

diff --git a/packages/coding-agent/test/utils/changelog-static-import.test.ts b/packages/coding-agent/test/utils/changelog-static-import.test.ts
index 369dc991a..b4d60c94d 100644
--- a/packages/coding-agent/test/utils/changelog-static-import.test.ts
+++ b/packages/coding-agent/test/utils/changelog-static-import.test.ts
@@ -3,6 +3,7 @@ import * as fs from "node:fs/promises";
 import * as os from "node:os";
 import * as path from "node:path";
 import { VERSION } from "@oh-my-pi/pi-utils";
+import type { BunPlugin } from "bun";
 import { resolveBundledChangelogPath } from "../../src/utils/changelog";
 
 interface HeapProbeResult {
@@ -34,6 +35,25 @@ async function runProbe(command: string[], cwd?: string): Promise<BundleProbeRes
 	return JSON.parse(stdout) as BundleProbeResult;
 }
 
+/**
+ * Swap `@oh-my-pi/pi-utils` and the changelog module's `../config` import for a
+ * dependency-free stub. Both pull the native addon loader into the bundle graph, and
+ * that loader resolves `pi_natives.<platform>.node` relative to the emitted artifact,
+ * so any probe written outside the repo fails to start. The subject under test is
+ * emitted-asset resolution, not native loading.
+ */
+function changelogUtilsStubPlugin(): BunPlugin {
+	return {
+		name: "changelog-utils-stub",
+		setup(build) {
+			build.onResolve({ filter: /^@oh-my-pi\/pi-utils$/ }, () => ({ path: utilsStubPath }));
+			build.onResolve({ filter: /^\.\.\/config$/ }, args =>
+				args.importer.endsWith("/utils/changelog.ts") ? { path: utilsStubPath } : undefined,
+			);
+		},
+	};
+}
+
 describe("bundled changelog asset path resolution", () => {
 	const moduleUrl = new URL("file:///opt/omp/dist/cli.js");
 
@@ -77,23 +97,14 @@ describe("changelog static import resources", () => {
 			await fs.mkdir(unrelatedCwd);
 			const sourceResult = await runProbe([process.execPath, bundleProbePath, missingPackageChangelogPath]);
 
-			const buildProc = Bun.spawn(
-				[
-					process.execPath,
-					"build",
-					bundleProbePath,
-					"--target=bun",
-					"--external=omp-legacy-pi-modules",
-					`--outdir=${bundleDir}`,
-				],
-				{ stderr: "pipe", stdout: "pipe" },
-			);
-			const [buildStdout, buildStderr, buildExitCode] = await Promise.all([
-				new Response(buildProc.stdout).text(),
-				new Response(buildProc.stderr).text(),
-				buildProc.exited,
-			]);
-			expect(buildExitCode, buildStdout + buildStderr).toBe(0);
+			const buildOutput = await Bun.build({
+				entrypoints: [bundleProbePath],
+				outdir: bundleDir,
+				target: "bun",
+				external: ["omp-legacy-pi-modules"],
+				plugins: [changelogUtilsStubPlugin()],
+			});
+			expect(buildOutput.success, buildOutput.logs.map(log => log.message).join("\n")).toBe(true);
 
 			const outputs = await fs.readdir(bundleDir);
 			expect(outputs.some(output => output.endsWith(".md"))).toBe(true);
@@ -124,17 +135,7 @@ describe("changelog static import resources", () => {
 				entrypoints: [bundleProbePath],
 				root: repoRoot,
 				external: ["omp-legacy-pi-modules"],
-				plugins: [
-					{
-						name: "changelog-utils-stub",
-						setup(build) {
-							build.onResolve({ filter: /^@oh-my-pi\/pi-utils$/ }, () => ({ path: utilsStubPath }));
-							build.onResolve({ filter: /^\.\.\/config$/ }, args =>
-								args.importer.endsWith("/utils/changelog.ts") ? { path: utilsStubPath } : undefined,
-							);
-						},
-					},
-				],
+				plugins: [changelogUtilsStubPlugin()],
 				compile: {
 					outfile: binaryPath,
 					autoloadBunfig: false,