smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(coding-agent): added overlay UI option and fixed viewport sync race conditions

Browse Source 
- Added overlay option to custom UI hooks for bottom-centered component display.
- Added automatic chat transcript rebuild when returning from custom or debug UI modes.
- Fixed race condition in bash interactive component preventing output append after closure.
- Extracted environment variable configuration into reusable NO_PAGER_ENV constant for bash execution.
- Fixed viewport synchronization issue in TUI causing terminal desync during full re-renders.
This commit is contained in:
can1357
2026-02-21 22:52:59 +01:00
parent 93e28a8029
commit 0b1514da61
9 changed files with 103 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/src/tools/bash-interactive.ts
+46 -42
View File
@@ -276,6 +276,50 @@ class BashInteractiveOverlayComponent implements Component {
}
}
const NO_PAGER_ENV = {
// Disable pagers so commands don't block on interactive views.
PAGER: "cat",
GIT_PAGER: "cat",
MANPAGER: "cat",
SYSTEMD_PAGER: "cat",
BAT_PAGER: "cat",
DELTA_PAGER: "cat",
GH_PAGER: "cat",
GLAB_PAGER: "cat",
PSQL_PAGER: "cat",
MYSQL_PAGER: "cat",
AWS_PAGER: "",
HOMEBREW_PAGER: "cat",
LESS: "FRX",
// Disable editor and terminal credential prompts.
GIT_EDITOR: "true",
VISUAL: "true",
EDITOR: "true",
GIT_TERMINAL_PROMPT: "0",
SSH_ASKPASS: "/usr/bin/false",
CI: "1",
// Package manager defaults for unattended execution.
npm_config_yes: "true",
npm_config_update_notifier: "false",
npm_config_fund: "false",
npm_config_audit: "false",
npm_config_progress: "false",
PNPM_DISABLE_SELF_UPDATE_CHECK: "true",
PNPM_UPDATE_NOTIFIER: "false",
YARN_ENABLE_TELEMETRY: "0",
YARN_ENABLE_PROGRESS_BARS: "0",
// Cross-language/tooling non-interactive defaults.
CARGO_TERM_PROGRESS_WHEN: "never",
DEBIAN_FRONTEND: "noninteractive",
PIP_NO_INPUT: "1",
PIP_DISABLE_PIP_VERSION_CHECK: "1",
TF_INPUT: "0",
TF_IN_AUTOMATION: "1",
GH_PROMPT_DISABLED: "1",
COMPOSER_NO_INTERACTION: "1",
CLOUDSDK_CORE_DISABLE_PROMPTS: "1",
};
export async function runInteractiveBashPty(
ui: NonNullable<AgentToolContext["ui"]>,
options: {
@@ -346,54 +390,14 @@ export async function runInteractiveBashPty(
timeoutMs: options.timeoutMs,
env: {
...options.env,
// Disable pagers so commands don't block on interactive views.
PAGER: "cat",
GIT_PAGER: "cat",
MANPAGER: "cat",
SYSTEMD_PAGER: "cat",
BAT_PAGER: "cat",
DELTA_PAGER: "cat",
GH_PAGER: "cat",
GLAB_PAGER: "cat",
PSQL_PAGER: "cat",
MYSQL_PAGER: "cat",
AWS_PAGER: "",
HOMEBREW_PAGER: "cat",
LESS: "FRX",
// Disable editor and terminal credential prompts.
GIT_EDITOR: "true",
VISUAL: "true",
EDITOR: "true",
GIT_TERMINAL_PROMPT: "0",
SSH_ASKPASS: "/usr/bin/false",
CI: "1",
// Package manager defaults for unattended execution.
npm_config_yes: "true",
npm_config_update_notifier: "false",
npm_config_fund: "false",
npm_config_audit: "false",
npm_config_progress: "false",
PNPM_DISABLE_SELF_UPDATE_CHECK: "true",
PNPM_UPDATE_NOTIFIER: "false",
YARN_ENABLE_TELEMETRY: "0",
YARN_ENABLE_PROGRESS_BARS: "0",
// Cross-language/tooling non-interactive defaults.
CARGO_TERM_PROGRESS_WHEN: "never",
DEBIAN_FRONTEND: "noninteractive",
PIP_NO_INPUT: "1",
PIP_DISABLE_PIP_VERSION_CHECK: "1",
TF_INPUT: "0",
TF_IN_AUTOMATION: "1",
GH_PROMPT_DISABLED: "1",
COMPOSER_NO_INTERACTION: "1",
CLOUDSDK_CORE_DISABLE_PROMPTS: "1",
...NO_PAGER_ENV,
},
signal: options.signal,
cols,
rows,
},
(err, chunk) => {
if (err || !chunk) return;
if (finished || err || !chunk) return;
component.appendOutput(chunk);
const normalizedChunk = normalizeCaptureChunk(chunk);
pendingChunks = pendingChunks.then(() => sink.push(normalizedChunk)).catch(() => {});